[MRESOLVER-278] On repository system shutdown #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cstamas
force-pushed
the
MRESOLVER-278-onSessionClose-rework
branch
from
7c687a1 to
71ca943
Compare
cstamas
force-pushed
the
MRESOLVER-278-onSessionClose-rework
branch
from
31d2a6f to
cc4c213
Compare
cstamas
changed the title
cstamas
force-pushed
the
MRESOLVER-278-onSessionClose-rework
branch
from
f31ce42 to
e1575d1
Compare
Key changes: * It is not session to register handlers against, but RepositorySystem * DefaultRepositorySystemSession class deprecated, but will work as intended with a slight semantic change (it's handlers are executed on repo system shutdown) * introduced MutableRepositorySystemSession and used instead, session creation should be done using RepositorySystem and handle it as a resource * locking: partially undo PR apache#196, but do not use System properties but container injecter parameters instead (works with SISU only!)
cstamas
force-pushed
the
MRESOLVER-278-onSessionClose-rework
branch
from
c3ccecd to
a8a550c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Drops problematic onSessionClose, keeps only onSystemClose support. Issue will be adjusted accordingly.
Key changes:
camelCasehttps://issues.apache.org/jira/browse/MRESOLVER-278