Don't add default empty list to excludes #255
Draft
+1
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR removes unnecessary code related to default excludes handling and fixes a typo in documentation. The DEFAULT_EXCLUDES constant (which was an empty array) has been removed along with the logic that would add it to combinedExcludes when empty. This is safe because the method already uses FileUtils.getDefaultExcludesAsList() when useDefaultExcludes is true.
Key Changes:
- Removed the unused
DEFAULT_EXCLUDESconstant (empty array) - Removed dead code that added
DEFAULT_EXCLUDESto empty exclude lists - Fixed typo in javadoc comment: "addionalExcludes" → "additionalExcludes"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.