Skip to content

Don't add default empty list to excludes #255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
elharo wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Don't add default empty list to excludes #255

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/main/java/org/apache/maven/plugins/source/AbstractSourceJarMojo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,6 @@
public abstract class AbstractSourceJarMojo implements Mojo {
private static final String[] DEFAULT_INCLUDES = new String[] {"**/**"};

private static final String[] DEFAULT_EXCLUDES = new String[] {};

/**
* List of files to include. Specified as fileset patterns which are relative to the input directory whose contents
* is being packaged into the JAR.
Expand Down Expand Up @@ -542,7 +540,7 @@ private String[] getCombinedIncludes(List<String> additionalIncludes) {

/**
* Combines the user parameter {@link #excludes}, the default excludes from plexus FileUtils, and the contents of
* the parameter addionalExcludes.
* the parameter additionalExcludes.
*
* @param additionalExcludes Additional excludes to add to the array
* @return The combined list of excludes.
Expand All @@ -562,10 +560,6 @@ private String[] getCombinedExcludes(List<String> additionalExcludes) {
combinedExcludes.addAll(additionalExcludes);
}

if (combinedExcludes.isEmpty()) {
combinedExcludes.addAll(Arrays.asList(DEFAULT_EXCLUDES));
}

return combinedExcludes.toArray(new String[0]);
}

Expand Down
Loading