[#11048] Fix race condition in MessageUtils #11049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oehme
changed the title
oehme
changed the title
cstamas
approved these changes
Aug 15, 2025
Wait for the AnsiConsole#systemInstall call in the FastTerminal background thread before uninstalling. Otherwise a quickly finishing build might leave the terminal and system streams in a broken state.
oehme
force-pushed
the
oehme/ansiconsole-race
branch
from
6fd1a05 to
6be3525
Compare
Member
|
This will need backport to 4.0.x as well |
Contributor
Author
|
Build failure looks unrelated, can you give this another go? |
gnodet
reviewed
Aug 27, 2025
Contributor
gnodet
left a comment
gnodet
left a comment
There was a problem hiding this comment.
Avoiding the cast would be nicer
impl/maven-jline/src/main/java/org/apache/maven/jline/MessageUtils.java
Outdated
Show resolved
Hide resolved
impl/maven-jline/src/main/java/org/apache/maven/jline/MessageUtils.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Guillaume Nodet <gnodet@gmail.com>
gnodet
approved these changes
Aug 27, 2025
cstamas
approved these changes
Aug 28, 2025
Contributor
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
gnodet
added a commit
to gnodet/maven
that referenced
this pull request
Aug 29, 2025
Wait for the AnsiConsole#systemInstall call in the FastTerminal background thread before uninstalling. Otherwise a quickly finishing build might leave the terminal and system streams in a broken state. Co-authored-by: Guillaume Nodet <gnodet@gmail.com> (cherry picked from commit bc52e2e)
gnodet
added a commit
that referenced
this pull request
Aug 29, 2025
Wait for the AnsiConsole#systemInstall call in the FastTerminal background thread before uninstalling. Otherwise a quickly finishing build might leave the terminal and system streams in a broken state. (cherry picked from commit bc52e2e) Co-authored-by: Stefan Oehme <st.oehme@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait for the AnsiConsole#systemInstall call in the FastTerminal background thread before uninstalling. Otherwise a quickly finishing build might leave the terminal and system streams in a broken state.
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.