Skip to content

[#11048] Fix race condition in MessageUtils #11049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gnodet merged 2 commits into from
Aug 29, 2025
Merged

[#11048] Fix race condition in MessageUtils #11049

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6be3525
[#11048] Fix race condition in MessageUtils
oehme Aug 15, 2025
96736dc
Apply suggestions from code review
oehme Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions impl/maven-jline/src/main/java/org/apache/maven/jline/MessageUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,10 @@ public static void systemUninstall() {

private static void doSystemUninstall() {
try {
if (terminal instanceof FastTerminal fastTerminal) {
// wait for the asynchronous systemInstall call before we uninstall to ensure a consistent state
fastTerminal.getTerminal();
}
AnsiConsole.systemUninstall();
} finally {
terminal = null;
Expand Down
Loading