Validate metaversions and detect extension conflicts (fixes #11181) #11184
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: * validate for metaversions in extensions XML * conflict detection should not report conflict for same V
cstamas
commented
Sep 27, 2025
| String ga = coreExtension.getGroupId() + ":" + coreExtension.getArtifactId(); | ||
| InputLocation location = coreExtension.getLocation(""); | ||
| gasLocations.computeIfAbsent(ga, k -> new ArrayList<>()).add(location); | ||
| // TODO: metaversions could be extensible enum with these two values out of the box |
Member
Author
There was a problem hiding this comment.
@gnodet maybe not extensible enum right now, but where would be their proper place? Maybe not even in API (to draw attention) for start, just some constants somewhere?
elharo
approved these changes
Sep 29, 2025
...it-suite/src/test/java/org/apache/maven/it/MavenITgh11181CoreExtensionsMetaVersionsTest.java
Outdated
Show resolved
Hide resolved
|
@cstamas Please assign appropriate label to PR according to the type of change. |
cstamas
added a commit
to cstamas/maven
that referenced
this pull request
Oct 8, 2025
…che#11184) Changes: * validate for metaversions in extensions XML * conflict detection should not report conflict for same V * support for metaversions during extension resolution Fixes apache#11181
cstamas
added a commit
that referenced
this pull request
Oct 8, 2025
gnodet
changed the title
gnodet
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Fixes #11181