chore: add test assertion to resolve @SuppressWarnings("checkstyle:UnusedLocalVariable")

[Pankraz76]

• add test assertion to resolve @SuppressWarnings("checkstyle:UnusedLocalVariable") #2365
• [POC-FIX-PMD] maven-pmd-plugin: reactivate PMD - Error Prone #2364

[Pankraz76]

whats he issue with this one?

• add test assertion to resolve @SuppressWarnings("checkstyle:UnusedLocalVariable") #2365

assuming its the same solution for common problem.

[desruisseaux]

This pull request provides small changes addressing exactly the discussion point, while #2365 is a larger set of changes which includes questionable changes (e.g. the introduction of the assertHeader method).

Addressing all PMD warnings should not be a goal. Many of them are harmless, and sometime complying to the rule make the code less understandable. Some warnings are indeed real issues (e.g. the while (vector.isEmpty()) loop in another PR), but the evaluation is on a case-by-case basis.

[Pankraz76]

which includes questionable changes (e.g. the introduction of the assertHeader method).

yes not applied SOC, sorry.

Addressing all PMD warnings should not be a goal.

kind of yes. I will check the most important.

[Pankraz76]

this could be merge as approved and just incremented the test little further.
merci.