Skip to content

chore: add test assertion to resolve @SuppressWarnings("checkstyle:UnusedLocalVariable") #2367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Pankraz76 wants to merge 1 commit into from
Closed

chore: add test assertion to resolve @SuppressWarnings("checkstyle:UnusedLocalVariable") #2367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 17 additions & 8 deletions ...c/test/java/org/apache/maven/repository/legacy/resolver/DefaultArtifactCollectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,17 +293,26 @@ void testResolveNearestWithRanges() throws ArtifactResolutionException, InvalidV
}

@Test
@SuppressWarnings("checkstyle:UnusedLocalVariable")
void testResolveRangeWithManagedVersion() throws ArtifactResolutionException, InvalidVersionSpecificationException {
ArtifactSpec a = createArtifactSpec("a", "1.0");
ArtifactSpec b = a.addDependency("b", "[1.0,3.0]");

String version = "1.0";
ArtifactSpec a = createArtifactSpec("a", version);
String versionRange = "[1.0,3.0]";
ArtifactSpec b = a.addDependency("b", versionRange);
ArtifactSpec managedB = createArtifactSpec("b", "5.0");

ArtifactResolutionResult res = collect(a, managedB.artifact);
assertEquals(
createSet(new Object[] {a.artifact, managedB.artifact}), res.getArtifacts(), "Check artifact list");
assertEquals("5.0", getArtifact("b", res.getArtifacts()).getVersion(), "Check version");

assertEquals(createSet(new Object[] {a.artifact, managedB.artifact}), res.getArtifacts());
assertEquals("5.0", getArtifact("b", res.getArtifacts()).getVersion());
assertArtifact(a, "a", version, a.artifact.getVersion());
assertArtifact(b, "b", versionRange, b.artifact.getVersionRange().toString());
}

private static void assertArtifact(ArtifactSpec artifactSpec, String artifactId, String version, String artifact) {
assertEquals("test", artifactSpec.artifact.getGroupId());
assertEquals(artifactId, artifactSpec.artifact.getArtifactId());
assertEquals(version, artifact);
assertEquals("compile", artifactSpec.artifact.getScope());
assertEquals("jar", artifactSpec.artifact.getType());
}

@Test
Expand Down