Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

fix update params #14218

Merged
merged 1 commit into from
Feb 21, 2019
Merged

fix update params #14218

merged 1 commit into from
Feb 21, 2019

Conversation

roywei
Copy link
Member

@roywei roywei commented Feb 21, 2019

Description

fix #14216
see detailed analysis in the issue.
I added a unit test although this may not be a common/correct use case in MXNet.

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • Build tests will be added for build configuration changes (e.g. adding a new build option with NCCL)
  • Code is well-documented:
  • For user-facing API changes, API doc string has been updated.
  • For new C++ functions in header files, their functionalities and arguments are documented.
  • For new examples, README.md is added to explain the what the example does, the source of the dataset, expected performance on test set and reference to the original paper if applicable
  • Check the API doc at http://mxnet-ci-doc.s3-accelerate.dualstack.amazonaws.com/PR-$PR_ID/$BUILD_ID/index.html
  • To the my best knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

add check for empty list

Comments

  • If this change is a backward incompatible change, why must this change be made.
  • Interesting edge cases to note here

@roywei roywei requested a review from szha as a code owner February 21, 2019 00:10
@roywei
Copy link
Member Author

roywei commented Feb 21, 2019

@eric-haibin-lin @apeforest @ptrendx could you help take a look? Thanks!

@roywei
Copy link
Member Author

roywei commented Feb 21, 2019

@mxnet-label-bot add[Module, Optimizer, Python, pr-awaiting-review]

Copy link
Member

@ptrendx ptrendx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@ChaiBapchya ChaiBapchya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for that deep dive (finding the bug) and then resolving it!

@eric-haibin-lin eric-haibin-lin merged commit fdbc433 into apache:master Feb 21, 2019
jessr92 pushed a commit to jessr92/incubator-mxnet that referenced this pull request Feb 28, 2019
jessr92 pushed a commit to jessr92/incubator-mxnet that referenced this pull request Feb 28, 2019
jessr92 pushed a commit to jessr92/incubator-mxnet that referenced this pull request Feb 28, 2019
drivanov pushed a commit to drivanov/incubator-mxnet that referenced this pull request Mar 4, 2019
vdantu pushed a commit to vdantu/incubator-mxnet that referenced this pull request Mar 31, 2019
haohuanw pushed a commit to haohuanw/incubator-mxnet that referenced this pull request Jun 23, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

update params failed when params and grads are empty
5 participants