fix update params (apache#14218)

python/mxnet/model.py

@@ -181,8 +181,10 @@ def _update_params(param_arrays, grad_arrays, updater, num_device,
  w, g = p
  updates[k].append((index*num_device+k, g, w))
  for dev_updates in updates:
- i, w, g = zip(*dev_updates)
- updater(i, w, g)
+ # update params if param_arrays and grad_arrays are not empty
+ if dev_updates:
+ i, w, g = zip(*dev_updates)
+ updater(i, w, g)
 
 
 def _multiple_callbacks(callbacks, *args, **kwargs):

tests/python/unittest/test_module.py

@@ -917,6 +917,20 @@ def sym_gen(_):
  assert(mod._curr_module._exec_group.execs[0].grad_dict['a'].asscalar() == 2 * batch_size)
 
 
+def test_module_update_no_pragram():
+ # test module to do update on layers without params
+ data_shape = (10, 10)
+ data = mx.sym.Variable('data')
+ out = mx.sym.Dropout(data, 0.5)
+ mod = mx.mod.Module(out)
+ mod.bind(data_shapes=[('data', data_shape)])
+ mod.init_params()
+ mod.init_optimizer()
+ data_batch = mx.io.DataBatch([nd.ones(data_shape)])
+ mod.forward_backward(data_batch)
+ mod.update()
+ assert(mod.get_outputs()[0].shape == data_shape)
+
 if __name__ == '__main__':
  import nose
  nose.runmodule()