-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[MKLDNN]Refactor requantize to speed up execution #14608
Conversation
@ZhennanQin Thanks for your contributions. Can you also look into the CI failures ? @mxnet-label-bot Add [pr-work-in-progress, Quantization, MKLDNN] |
@ZhennanQin further action for this PR? |
@ZhennanQin the patch could not be applied for with #14641 diff a/src/operator/quantization/mkldnn/mkldnn_quantize_v2-inl.h b/src/operator/quantization/mkldnn/mkldnn_quantize_v2-inl.h (rejected hunks)
|
@ZhennanQin please take a look at the conflicts and CI failures. Thank you. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
Thanks all of the contribution. Merging now :) |
* Refactor requantize * fix ci * Fix CI * Fix ci
* Refactor requantize * fix ci * Fix CI * Fix ci
Description
Currently, requantize is too slow to use. This PR is to refactor its MKLDNN implementation to make it usable. Other change is, add out_type option to make it align with quantizeV2. Now requantize can support output uint8 if could.
@pengzhao-intel @TaoLv @reminisce @anirudh2290
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments