This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[MKLDNN]Improve quantizeV2 and dequantize latency #14641
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhennanQin
force-pushed
the
stateful_quantize
branch
from
April 8, 2019 08:21
bffa5d8
to
04a7589
Compare
@ZhennanQin Thanks for your contributions. Can you look at the CI failures ? |
marcoabreu
added
pr-work-in-progress
PR is still work in progress
Quantization
Issues/Feature Requests related to Quantization
labels
Apr 8, 2019
@piyushghai ping for any further comments? |
7 tasks
ZhennanQin
changed the title
[WIP]stateful_quantize
[MKLDNN]Improve quantizeV2 and dequantize latency
Apr 16, 2019
anirudh2290
reviewed
Apr 16, 2019
ZhennanQin
force-pushed
the
stateful_quantize
branch
from
April 17, 2019 01:10
8add4db
to
a9dcd4d
Compare
anirudh2290
approved these changes
Apr 17, 2019
pengzhao-intel
approved these changes
Apr 18, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The change has been verified internally by our auto-ci with real models :)
@anirudh2290 Thanks for the review and really good suggestions.
Merging now. |
kedarbellare
pushed a commit
to kedarbellare/incubator-mxnet
that referenced
this pull request
Apr 20, 2019
* stateful_quantize * fix lint * Fix build * fix gpu build * Fix typo * Move check to online calibration
haohuanw
pushed a commit
to haohuanw/incubator-mxnet
that referenced
this pull request
Jun 23, 2019
* stateful_quantize * fix lint * Fix build * fix gpu build * Fix typo * Move check to online calibration
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
pr-work-in-progress
PR is still work in progress
Quantization
Issues/Feature Requests related to Quantization
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change quantizeV2 and dequantize to stateful op to improve small batch size performance.
@pengzhao-intel @TaoLv @reminisce @zheng-da @anirudh2290
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes
Comments