-
Notifications
You must be signed in to change notification settings - Fork 6.8k
Disable OpenMP offloading support for 3rdparty/openmp #17098
Conversation
OpenMP offloading was introduced some time during the past two years and is enabled by default. With upgrading 3rdparty/openmp in apache#17012 it was made part of the MXNet CMake build. But we don't use OpenMP offloading and the Cuda target in the llvm OpenMP Offloading build is broken in our setting.
* Disable OpenMP offloading support for 3rdparty/openmp OpenMP offloading was introduced some time during the past two years and is enabled by default. With upgrading 3rdparty/openmp in apache#17012 it was made part of the MXNet CMake build. But we don't use OpenMP offloading and the Cuda target in the llvm OpenMP Offloading build is broken in our setting. * Update CMake on CI
* Upgrade 3rdparty/openmp to release_90 version (#17012) Fixes #10856 * Fix omp assert issue (#17039) * Disable OpenMP offloading support for 3rdparty/openmp (#17098) * Disable OpenMP offloading support for 3rdparty/openmp OpenMP offloading was introduced some time during the past two years and is enabled by default. With upgrading 3rdparty/openmp in #17012 it was made part of the MXNet CMake build. But we don't use OpenMP offloading and the Cuda target in the llvm OpenMP Offloading build is broken in our setting. * Update CMake on CI * Fix reshape interoperability test (#17155) * fix reshape interoperability test * fix for scipy import Co-authored-by: Chris Olivier <cjolivier01@gmail.com> Co-authored-by: Hao Jin <hjjn.amzn@gmail.com>
@leezu im getting this error in my windows CI runs:
I think this is coming from here: |
@samskalicky above lines are a temporary workaround until the Base Windows AMI used by CI is updated. @larroy may be able to give an estimate when it's possible to update. |
The reason for using a tmpdir is that multiple jobs are executed on the same Windows CI server. In an earlier stage of this PR I used a fixed path but got a race condition during the cmake installation. I'm not sure why above cleanup error occurs rarely. |
Any reason you are not using the Jenkins workspace? That one is guaranteed to be exclusively to the current job |
@marcoabreu no reason. In principle |
We will remove that when we update CMake on windows, pending some issues with CMake & Visual studio |
I'm still seeing the PermissionError. Here is an issue for it. #17558 |
Description
OpenMP offloading was introduced some time during the past two years and is
enabled by default. With upgrading 3rdparty/openmp in
#17012 it was unintentionally made part of the MXNet CMake build.
But we don't use OpenMP offloading and the Cuda target in the llvm OpenMP
Offloading build is broken in our setting. Thus disable it.
Due to bug in CMake < 3.13, this requires updating to CMake 3.13. See https://cmake.org/cmake/help/latest/policy/CMP0077.html
Checklist
Essentials
Please feel free to remove inapplicable items for your PR.
Changes