This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
Backport 3rdparty/openmp fixes #17193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Disable OpenMP offloading support for 3rdparty/openmp OpenMP offloading was introduced some time during the past two years and is enabled by default. With upgrading 3rdparty/openmp in apache#17012 it was made part of the MXNet CMake build. But we don't use OpenMP offloading and the Cuda target in the llvm OpenMP Offloading build is broken in our setting. * Update CMake on CI
leezu
requested review from
aaronmarkham,
marcoabreu and
szha
as code owners
|
@leezu is there a fix for those numpy errors? We need to backport that as well. |
ptrendx
approved these changes
Dec 30, 2019
|
@ptrendx no real fix yet as far as I'm aware. For now numpy 1.18 is marked as unsupported. I'll include the commit that marks 1.18 as unsupported. |
* fix reshape interoperability test * fix for scipy import
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport #17098 #17039 #17012 #17155
The commits contain fixes for the cmake build with openmp enabled.
The cmake build is not used for binary releases on pypi, but the fixes may be helpful for people or organizations building with cmake from source.