Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[Bug Fix] Fix GroupNorm Implementation #18199

Merged
merged 2 commits into from
Apr 30, 2020
Merged

[Bug Fix] Fix GroupNorm Implementation #18199

merged 2 commits into from
Apr 30, 2020

Conversation

hgt312
Copy link
Contributor

@hgt312 hgt312 commented Apr 30, 2020

See #17139.

@hgt312 hgt312 requested a review from szha as a code owner April 30, 2020 04:20
@mxnet-bot
Copy link

Hey @hgt312 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [clang, website, windows-cpu, windows-gpu, unix-gpu, sanity, centos-cpu, unix-cpu, edge, miscellaneous, centos-gpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

yzhliu
yzhliu approved these changes Apr 30, 2020
View reviewed changes
Copy link
Member

@yzhliu yzhliu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sxjscience pls also take a look.

@sxjscience
Copy link
Member

sxjscience commented Apr 30, 2020 •
edited
Loading

LGTM, FYI @Jerryzcn @zhreshold

sxjscience
sxjscience reviewed Apr 30, 2020
View reviewed changes
python/mxnet/gluon/nn/basic_layers.py
allow_deferred_init=True)
self.beta = self.params.get('beta', grad_req='write' if center else 'null',
shape=(num_groups,), init=beta_initializer,
shape=(in_channels,), init=beta_initializer,
allow_deferred_init=True)

def hybrid_forward(self, F, data, gamma, beta):
norm_data = F.GroupNorm(data, gamma=gamma, beta=beta, num_groups=self._num_groups, eps=self._epsilon)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just realized one quick issue. Should we consider to move GroupNorm to npx? Currently, the layer won’t be usable in the new numpy interface. @zhreshold

@sxjscience sxjscience merged commit 1496c91 into apache:master Apr 30, 2020
@sxjscience
Copy link
Member

I've merged this PR because it's a bugfix. If we need GroupNorm in npx, we can register it under the npx namespace.

@yzhliu
Copy link
Member

yzhliu commented Apr 30, 2020

We should have a list of ops that need to be migrated.

@yzhliu yzhliu mentioned this pull request Apr 30, 2020
Closed
@nickguletskii nickguletskii mentioned this pull request May 9, 2020
Open
10 tasks
AntiZpvoh pushed a commit to AntiZpvoh/incubator-mxnet that referenced this pull request Jul 6, 2020
@hgt312 @AntiZpvoh
[Bug Fix] Fix GroupNorm Implementation (apache#18199)
2a48960 
* init

* add in_channels
chinakook pushed a commit to chinakook/mxnet that referenced this pull request Jul 23, 2020
@hgt312 @chinakook
[Bug Fix] Fix GroupNorm Implementation (apache#18199)
9bfcc7f 
* init

* add in_channels
@chinakook chinakook mentioned this pull request Nov 19, 2020
Closed
@trevor-m trevor-m mentioned this pull request Feb 4, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sxjscience sxjscience sxjscience left review comments

@yzhliu yzhliu yzhliu approved these changes

@szha szha Awaiting requested review from szha szha is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hgt312 @mxnet-bot @sxjscience @yzhliu