Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[WIP][DO NOT MERGE] Add large tensor test for linalg_dgemm2 #18718

Closed
wants to merge 1 commit into from

Conversation

access2rohit
Copy link
Contributor

Description

checks for correctness for linalg_gemm2 operator for Large Matrices

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Unit tests are added for small changes to verify correctness (e.g. adding a new operator)
  • Nightly tests are added for complicated/long-running ones (e.g. changing distributed kvstore)
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Test Results

(pytest) ubuntu@ip-172-31-90-243 ~/workspace/incubator-mxnet (example) $ python -m pytest -s --exitfirst --verbose tests/nightly/test_large_array.py::test_linalg_ops
=============================================================================================== test session starts ===============================================================================================
platform linux -- Python 3.6.10, pytest-5.3.5, py-1.8.2, pluggy-0.13.1 -- /home/ubuntu/anaconda3/envs/pytest/bin/python
cachedir: .pytest_cache
rootdir: /home/ubuntu/workspace/incubator-mxnet, inifile: pytest.ini
collected 1 item

tests/nightly/test_large_array.py::test_linalg_ops [16:43:23] ../src/operator/numpy/linalg/./../../tensor/../linalg_impl.h:157: inside cblas_gemm
PASSED

================================================================================================ warnings summary =================================================================================================
/home/ubuntu/anaconda3/envs/pytest/lib/python3.6/site-packages/_pytest/mark/structures.py:327
  /home/ubuntu/anaconda3/envs/pytest/lib/python3.6/site-packages/_pytest/mark/structures.py:327: PytestUnknownMarkWarning: Unknown pytest.mark.timeout - is this a typo?  You can register custom marks to avoid this warning - for details, see https://docs.pytest.org/en/latest/mark.html
    PytestUnknownMarkWarning,

-- Docs: https://docs.pytest.org/en/latest/warnings.html
==================================================================================== 1 passed, 1 warning in 142.42s (0:02:22) =====================================================================================

@mxnet-bot
Copy link

Hey @access2rohit , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-cpu, unix-cpu, centos-gpu, clang, centos-cpu, unix-gpu, windows-gpu, edge, miscellaneous, sanity, website]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@access2rohit access2rohit changed the title add large tensor test for matmul [WIP]add large tensor test for matmul Jul 15, 2020
@access2rohit
Copy link
Contributor Author

@ChaiBapchya @mseth10 can you review ?

@access2rohit
Copy link
Contributor Author

@mxnet-label-bot add [pr-awaiting-review]

@lanking520 lanking520 added the pr-awaiting-review PR is waiting for code review label Jul 15, 2020
@access2rohit access2rohit changed the title [WIP]add large tensor test for matmul Add large tensor test for matmul Jul 15, 2020
@access2rohit access2rohit changed the title Add large tensor test for matmul Add large tensor test for linalg_dgemm2 Jul 15, 2020
Copy link
Contributor

@mseth10 mseth10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szha
Copy link
Member

szha commented Jul 16, 2020

we are deprecating ndarray in 2.0 soon. we should start migrating tests to numpy arrays instead

@access2rohit access2rohit changed the base branch from master to v1.x July 28, 2020 23:58
@access2rohit access2rohit changed the title Add large tensor test for linalg_dgemm2 [WIP][DO NOT MERGE] Add large tensor test for linalg_dgemm2 Jul 29, 2020
@access2rohit
Copy link
Contributor Author

we are deprecating ndarray in 2.0 soon. we should start migrating tests to numpy arrays instead

Changed it to v1.x

@ChaiBapchya
Copy link
Contributor

@access2rohit as linked in this PR: #18784 I already added forward & backward test for linalg.gemm2 in v1.x

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants