Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[1.x][LT] Add forward, backward test for linalg.gemm2 #18784

Merged
merged 7 commits into from
Jul 28, 2020

Conversation

ChaiBapchya
Copy link
Contributor

@ChaiBapchya ChaiBapchya commented Jul 24, 2020

Description

Related PR: #18718

Checklist

Essentials

Please feel free to remove inapplicable items for your PR.

  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage:
  • Code is well-documented:
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@mxnet-bot
Copy link

Hey @ChaiBapchya , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [unix-gpu, sanity, windows-gpu, clang, windows-cpu, unix-cpu, centos-cpu, miscellaneous, centos-gpu, website, edge]


Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@ChaiBapchya ChaiBapchya changed the title added forward, backward test for linalg.gemm2 [1.x][LT] Add forward, backward test for linalg.gemm2 Jul 24, 2020
@ChaiBapchya
Copy link
Contributor Author

@mxnet-label-bot add [pr-awaiting-review]

@lanking520 lanking520 added the pr-awaiting-review PR is waiting for code review label Jul 24, 2020
Copy link
Contributor

@mseth10 mseth10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ChaiBapchya
Copy link
Contributor Author

Test results:

python -m pytest -s --exitfirst --verbose tests/nightly/test_large_array.py::test_gemm2
==================================================== test session starts =====================================================
platform linux -- Python 3.7.7, pytest-5.4.3, py-1.9.0, pluggy-0.13.1 -- /home/ubuntu/gemm2_test_venv/bin/python
cachedir: .pytest_cache
rootdir: /home/ubuntu/chai-mxnet
collected 1 item

tests/nightly/test_large_array.py::test_gemm2 [23:35:35] ../src/base.cc:84: Upgrade advisory: this mxnet has been built against cuDNN lib version 7501, which is older than the oldest version tested by CI (7600).  Set MXNET_CUDNN_LIB_CHECKING=0 to quiet this
warning.
PASSED

======================================================================================================================== warnings summary ========================================================================================================================
/home/ubuntu/gemm2_test_venv/lib/python3.7/site-packages/nose/importer.py:12
  /home/ubuntu/gemm2_test_venv/lib/python3.7/site-packages/nose/importer.py:12: DeprecationWarning: the imp module is deprecated in favour of importlib; see the module's documentation for alternative uses
    from imp import find_module, load_module, acquire_lock, release_lock

-- Docs: https://docs.pytest.org/en/latest/warnings.html
============================================================================================================ 1 passed, 1 warning in 192.18s (0:03:12) ============================================================================================================

@mseth10
Copy link
Contributor

mseth10 commented Jul 27, 2020

@ChaiBapchya file conflicts need resolving

@ChaiBapchya
Copy link
Contributor Author

Reran after adding shape check

python3 -m pytest -s --exitfirst --verbose tests/nightly/test_large_array.py::test_linalg
========================================================= test session starts =========================================================
platform linux -- Python 3.7.7, pytest-5.4.1, py-1.8.1, pluggy-0.13.1 -- /home/ubuntu/anaconda3/bin/python3
cachedir: .pytest_cache
hypothesis profile 'default' -> database=DirectoryBasedExampleDatabase('/home/ubuntu/chai-mxnet/.hypothesis/examples')
rootdir: /home/ubuntu/chai-mxnet
plugins: remotedata-0.3.2, openfiles-0.4.0, astropy-header-0.1.2, hypothesis-5.8.3, arraydiff-0.3, doctestplus-0.5.0
collected 1 item

tests/nightly/test_large_array.py::test_linalg [23:12:33] ../src/base.cc:84: Upgrade advisory: this mxnet has been built against cuDNN
lib version 7501, which is older than the oldest version tested by CI (7600).  Set MXNET_CUDNN_LIB_CHECKING=0 to quiet this warning.
PASSED

========================================================== warnings summary ==========================================================$
/home/ubuntu/anaconda3/lib/python3.7/site-packages/nose/importer.py:12
  /home/ubuntu/anaconda3/lib/python3.7/site-packages/nose/importer.py:12: DeprecationWarning: the imp module is deprecated in favour o$
 importlib; see the module's documentation for alternative uses
    from imp import find_module, load_module, acquire_lock, release_lock

-- Docs: https://docs.pytest.org/en/latest/warnings.html
============================================== 1 passed, 1 warning in 142.52s (0:02:22) ==============================================

Copy link
Contributor

@access2rohit access2rohit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ChaiBapchya
Copy link
Contributor Author

@mxnet-label-bot update [pr-awaiting-merge]

@lanking520 lanking520 added pr-awaiting-merge Review and CI is complete. Ready to Merge and removed pr-awaiting-review PR is waiting for code review labels Jul 28, 2020
@szha szha merged commit d009345 into apache:v1.x Jul 28, 2020
@ChaiBapchya ChaiBapchya deleted the add_lt_gemm2 branch July 28, 2020 04:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr-awaiting-merge Review and CI is complete. Ready to Merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants