Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[DOC] remove mxtheme from source tree #19873

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[DOC] remove mxtheme from source tree #19873

wants to merge 3 commits into from

Conversation

szha
Copy link
Member

@szha szha commented Feb 9, 2021

Description

Per vote feedback on 1.8, this PR removes mxtheme from the source tree so that it's not included in source releases.

Checklist

Essentials

  • PR's title starts with a category (e.g. [BUGFIX], [MODEL], [TUTORIAL], [FEATURE], [DOC], etc)
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented

Changes

  • switch to mxtheme=0.3.14 pip package for doc build logic.

@szha szha requested a review from aaronmarkham as a code owner February 9, 2021 17:45
@mxnet-bot
Copy link

Hey @szha , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [website, sanity, edge, clang, windows-cpu, centos-gpu, miscellaneous, windows-gpu, unix-gpu, centos-cpu, unix-cpu]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 9, 2021
@szha szha requested a review from marcoabreu as a code owner February 9, 2021 19:09
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 9, 2021
@szha szha mentioned this pull request Feb 10, 2021
Merged
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 12, 2021
@szha
Copy link
Member Author

szha commented Feb 13, 2021

@mxnet-bot run ci [centos-gpu, windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [centos-gpu, windows-gpu]

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 13, 2021
@szha
Copy link
Member Author

szha commented Feb 14, 2021

@mxnet-bot run ci [windows-gpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [windows-gpu]

@lanking520 lanking520 removed the pr-work-in-progress PR is still work in progress label Feb 14, 2021
@lanking520 lanking520 added pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Feb 14, 2021
@szha
Copy link
Member Author

szha commented Feb 15, 2021

@josephevans the master branch windows gpu tests are failing on the ONNX tests. Could you help take a look?

@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 16, 2021
szha added 3 commits February 16, 2021 10:23
@szha
remove mxtheme from source tree
76aba0d 
Signed-off-by: Sheng Zha <zhasheng@amazon.com>
@szha
update CI and license
0a5fb3f 
Signed-off-by: Sheng Zha <zhasheng@amazon.com>
@szha
update mxtheme to 0.3.15
3b21137 
Signed-off-by: Sheng Zha <zhasheng@amazon.com>
@lanking520 lanking520 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress pr-awaiting-review PR is waiting for code review and removed pr-work-in-progress PR is still work in progress pr-awaiting-testing PR is reviewed and waiting CI build and test labels Feb 16, 2021
leezu
leezu suggested changes Feb 17, 2021
View reviewed changes
Copy link
Contributor

@leezu leezu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's figure out how to include the changes by #18845 #18639 etc before merging this. Thanks @aaronmarkham

@szha
Copy link
Member Author

szha commented Mar 2, 2021

I found ways to override both the templates and css/js. I will attempt to include the changes through these overrides.

@josephevans josephevans mentioned this pull request Mar 3, 2021
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@leezu leezu leezu requested changes

@josephevans josephevans josephevans approved these changes

@aaronmarkham aaronmarkham Awaiting requested review from aaronmarkham aaronmarkham is a code owner

@marcoabreu marcoabreu Awaiting requested review from marcoabreu marcoabreu is a code owner

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@szha @mxnet-bot @leezu @josephevans @lanking520