-
Notifications
You must be signed in to change notification settings - Fork 6.8k
[WIP] [v1.x] Create tool for building source archives #19972
Conversation
Hey @josephevans , Thanks for submitting the PR
CI supported jobs: [centos-gpu, unix-gpu, edge, clang, windows-cpu, unix-cpu, centos-cpu, miscellaneous, windows-gpu, website, sanity] Note: |
@josephevans Does this same tool also work for master? |
There will be some slight modifications for master (there's no R-package in master, which we remove in v1.x.) |
…ill not be distributing these in the source archive.
…it in the create_source_archive.sh script.
…nce we will not be distributing these in the source archive." This reverts commit 123cb72.
One idea is to automatically remove lines fro LICENSE that match a line in |
…directories. Also manually remove .github.
It would be great to add a check for all files listed in license and warn if any doesn't exist |
…ast, remove branch parameter since we no longer need it.
Added this to the script. Found 2 items in the LICENSE file that are no longer in the source tree and removed them. Perhaps this should be part of the normal sanity rat check CI pipeline so we catch the issues earlier instead of at release time. WDYT? But that will have to be part of a different PR. |
…ce build process.
OK, I updated to remove lines in LICENSE for stuff we remove the source archive. |
Description
This PR introduces a script that automates creating a release source archive and handles some licensing issues by removing some files that were identified to be non-compliant, and introducing a Apache RAT license check in the source generation process to ensure all Apache MXNet code is compliant.