Skip to content
This repository has been archived by the owner on Nov 17, 2023. It is now read-only.

[operator] Integrate matmul primitive from oneDNN in batch dot #20340

Merged
merged 5 commits into from
Jun 24, 2021
Merged

[operator] Integrate matmul primitive from oneDNN in batch dot #20340

merged 5 commits into from
Jun 24, 2021

Conversation

bartekkuncer
Copy link
Contributor

@bartekkuncer bartekkuncer commented Jun 10, 2021 •
edited
Loading

Description

This change integrates oneDNNs matmul primitive into batch dot execution.

Checklist

Changes

  • Integrate oneDNNs primitive

@mxnet-bot
Copy link

Hey @bartekkuncer , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:

  • To trigger all jobs: @mxnet-bot run ci [all]
  • To trigger specific jobs: @mxnet-bot run ci [job1, job2]

CI supported jobs: [windows-gpu, centos-gpu, miscellaneous, windows-cpu, unix-cpu, website, unix-gpu, sanity, centos-cpu, clang, edge]

Note:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.

@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress labels Jun 10, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test and removed pr-work-in-progress PR is still work in progress labels Jun 11, 2021
@bartekkuncer bartekkuncer force-pushed the batch_dot branch 2 times, most recently from cfe743f to bde0545 Compare June 11, 2021 11:15
bgawrych
bgawrych approved these changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@bgawrych bgawrych left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mozga-intel
mozga-intel suggested changes Jun 11, 2021
View reviewed changes
Copy link
Contributor

@mozga-intel mozga-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to figure out how to remove the static inline, but otherwise this looks good!

src/operator/nn/mkldnn/mkldnn_batch_dot.cc Show resolved Hide resolved
src/operator/tensor/dot.cc Outdated Show resolved Hide resolved
@mseth10 mseth10 added pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jun 11, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-work-in-progress PR is still work in progress and removed pr-awaiting-review PR is waiting for code review pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jun 23, 2021
@bartekkuncer
Copy link
Contributor Author

@mxnet-bot run ci [unix-cpu]

@mxnet-bot
Copy link

Jenkins CI successfully triggered : [unix-cpu]

@mseth10 mseth10 removed the pr-work-in-progress PR is still work in progress label Jun 24, 2021
@mseth10 mseth10 added pr-awaiting-testing PR is reviewed and waiting CI build and test pr-awaiting-review PR is waiting for code review and removed pr-awaiting-testing PR is reviewed and waiting CI build and test labels Jun 24, 2021
@akarbown akarbown merged commit 7b4d61d into apache:master Jun 24, 2021
@bartekkuncer bartekkuncer deleted the batch_dot branch June 24, 2021 10:01
@bartekkuncer bartekkuncer mentioned this pull request Jun 24, 2021
Merged
chinakook pushed a commit to chinakook/mxnet that referenced this pull request Aug 4, 2021
@bartekkuncer @chinakook
[operator] Integrate matmul primitive from oneDNN in batch dot (apach…
ff54582 
…e#20340)

* [operator] Integrate matmul primitive from oneDNN in batch dot

* Fix test_npx_batch_dot

* Remove 'inline static' from BatchDotStorageType

* Apply clang-formater

* Add static to bool BatchDotStorageType function
chinakook added a commit to chinakook/mxnet that referenced this pull request Aug 7, 2021
@chinakook
Revert "[operator] Integrate matmul primitive from oneDNN in batch dot (
2c57a96 
apache#20340)"

This reverts commit ff54582.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@akarbown akarbown akarbown left review comments

@mozga-intel mozga-intel mozga-intel requested changes

@bgawrych bgawrych bgawrych approved these changes

Assignees
No one assigned
Labels
pr-awaiting-review PR is waiting for code review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bartekkuncer @mxnet-bot @mozga-intel @bgawrych @akarbown @mseth10