Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update FlatLaf from 3.3 to 3.5 #7565

Merged
merged 1 commit into from
Jul 17, 2024
Merged

Update FlatLaf from 3.3 to 3.5 #7565

merged 1 commit into from
Jul 17, 2024

Conversation

mbien
Copy link
Member

@mbien mbien commented Jul 12, 2024 •
edited
Loading

@mbien mbien added Upgrade Library Library (Dependency) Upgrade Look and Feel UI User Interface ci:all-tests [ci] enable all tests ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) labels Jul 12, 2024
@mbien mbien added this to the NB23 milestone Jul 12, 2024
@mbien mbien removed the ci:all-tests [ci] enable all tests label Jul 12, 2024
@mbien mbien mentioned this pull request Jul 12, 2024
Closed
@mbien mbien requested a review from DevCharly July 12, 2024 17:48
@mbien mbien mentioned this pull request Jul 12, 2024
Merged
@neilcsmith-net
Copy link
Member

We may also have to keep in mind the option to revert to 3.2.5 for NB23 given #7560

@mbien
Copy link
Member Author

mbien commented Jul 13, 2024

We may also have to keep in mind the option to revert to 3.2.5 for NB23 given #7560

@neilcsmith-net yep, had the same thought. Lets gather some info what version works best and then we switch to it ;)

@mbien
Copy link
Member Author

mbien commented Jul 16, 2024

@DevCharly let me refresh this PR to v3.5

@mbien mbien changed the title Update FlatLaf from 3.3 to 3.4.1 Update FlatLaf from 3.3 to 3.5 Jul 16, 2024
@mbien
Update FlatLaf from 3.3 to 3.5
55aa90d 
 - show-favorites-in-file-chooser is now no longer experimental
   since flatlaf wraps the sidebar in a scroll pane now, which creates
   a consistent look between the NB dir chooser and JDK file choosers
 - flatlaf disabled rounded corners for popups on mac to workaround
   crashes
@mbien mbien marked this pull request as ready for review July 17, 2024 14:19
@mbien mbien linked an issue Jul 17, 2024 that may be closed by this pull request
Netbeans 22 crashes on MAC (14.5) #7560
Closed
eirikbakke
eirikbakke approved these changes Jul 17, 2024
View reviewed changes
Copy link
Contributor

@eirikbakke eirikbakke left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another FlatLAF release; excellent! Yes, if there was any kind of crash fixed by the new version, upgrading is good.

As someone mentioned there were some specific problems with MacOS 14.4.0 that caused Java apps such as IntelliJ to crash. Those problems were fixed in MacOS 14.4.1. Not sure if they were the cause of the reported FlatLAF-related crashes or not. (Edit: Probably not, since the reporter of this NetBeans crash was on MacOS 14.0 rather than MacOS 14.4.0.)

@mbien
Copy link
Member Author

mbien commented Jul 17, 2024

thanks for the reviews, merging

@eirikbakke yep the issues were about mac 14.5 by now and got mixed up with the original issue of mac 14.0.

it is also not clear to me if the issue concerns only popups on mac 14.5 or if it goes deeper. I guess we will find out :)

i am also likely going to close "lazy reports" in future which simply refer to another issue without going into details to keep things focused. Locking old issues might work too.

@mbien mbien merged commit 0f413a1 into apache:master Jul 17, 2024
31 checks passed
eirikbakke added a commit to eirikbakke/incubator-netbeans that referenced this pull request Aug 12, 2024
@eirikbakke
Update FlatLaf from 3.3 to 3.5 (manually applied PR apache#7565)
624c7f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eirikbakke eirikbakke eirikbakke approved these changes

@neilcsmith-net neilcsmith-net neilcsmith-net approved these changes

@DevCharly DevCharly DevCharly approved these changes

Assignees
No one assigned
Labels
ci:dev-build [ci] produce a dev-build zip artifact (7 days expiration, see link on workflow summary page) Look and Feel UI User Interface Upgrade Library Library (Dependency) Upgrade
Projects
None yet
Milestone
NB23
Development

Successfully merging this pull request may close these issues.

Netbeans 22 crashes on MAC (14.5)
4 participants
@mbien @neilcsmith-net @eirikbakke @DevCharly