-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIFI-13976: Adding endpoints to support copying and pasting flow cont… #9535
Open
mcgilman
wants to merge
2
commits into
apache:main
Choose a base branch
from
mcgilman:NIFI-13976
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ents. - Including the revision for the current Process Group in the flow response. - Introduce a method propose built for adding new versioned components to an existing Process Group. - Updating the paste response payload to only include the entities for the components that were just added. - Always generating new IDs when copying components. - Creating an ID for the copy action. - Code clean up. - Mapping IDs on paste to ensure connections are created correctly. - Authorizing any components whose instance IDs are specified. - Copying any sensitive properties from copied instances when pasting. - Fixing mapping of copy response to ensure that nested Controller Services can be referenced. - Including external Controller Services in copy response to they can be resolved on paste. - Excluding unreferenced services from copy response. - Including property descriptors to allow external services to resolve when pasting. - Including Parameters and Parameter Providers in copy response. - Fixing issue returning unreferenced services in the current process group. - Reverting changes building up external service references. - Only including external services that are references by the copy selection. - Adding some additional test coverage. - Adding consideration for the current ids in the paste id mapping. - Adding an endpoint response merger for the paste endpoint. - Including version control information in copy response. - Being more lenient when pasting unknown registry clients. - Ensuring groups IDs are mapped correctly when and when not versioned. - Including registry client id in vci of versioned process groups. - Updating copy/paste logic in existing system tests to leverage new endpoints. - Restoring originally proposed port name if possible. - Allow ports to be pasted into the root group. - Fixing authorization issue when pasting a flow containing Parameter Providers. - Fixing issue when authorizing exporting a Flow that contains a Process Group bound to a Parameter Context. - Introducing some Copy/Paste system tests. - Adding system tests for verify various copy paste functionality. - Fix checkstyle issue. - Fixing checkstyle issues. - Ensuring appropriate access around Parameter Providers following resolution based on locally available Parameter Providers. - Ensuring user has access to controller services directly referenced. - Fixing NPE in log message of Parameter Context. - Adding more copy/paste system tests. - Moving copy/paste version tests into the CopyPasteIT. - Fixing unit test mocking. - Include service authorization based on versioned component id since it may resolve during synchronization. - Skipping properties with no values when resolving service identifiers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the detailed work on the support for copy-paste @mcgilman. I ran through an initial code review and noted a few minor questions and comments.
...amework/nifi-client-dto/src/main/java/org/apache/nifi/web/api/entity/CopyResponseEntity.java
Outdated
Show resolved
Hide resolved
...i-web/nifi-web-api/src/main/java/org/apache/nifi/authorization/ProcessGroupAuthorizable.java
Show resolved
Hide resolved
...i-web/nifi-web-api/src/main/java/org/apache/nifi/authorization/ProcessGroupAuthorizable.java
Outdated
Show resolved
Hide resolved
...i-web/nifi-web-api/src/main/java/org/apache/nifi/authorization/ProcessGroupAuthorizable.java
Show resolved
Hide resolved
...mework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java
Outdated
Show resolved
Hide resolved
...mework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java
Show resolved
Hide resolved
...mework/nifi-web/nifi-web-api/src/main/java/org/apache/nifi/web/api/ProcessGroupResource.java
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ents.
This PR can be tested with the corresponding front end changes available in this PR [1].
[1] #9536