[NIFI-13977] - Updated Copy/Paste in UI to align with new backend API #9536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* center pasted elements on screen. zoom out to fit them if needed * offset pasted components if the originally copied content is still in view
rfellows
added
the
new ui
mcgilman
reviewed
Nov 21, 2024
Comment on lines
137
to
142
| // this.store | ||
| // .select(selectCopiedSnippet) | ||
| // .pipe(takeUntilDestroyed(this.destroyRef)) | ||
| // .subscribe((copiedSnippet) => { | ||
| // this.copiedSnippet = copiedSnippet; | ||
| // }); |
There was a problem hiding this comment.
Should this have been removed?
|
|
||
| return from( | ||
| this.snippetService.copySnippet(response.snippet.id, pasteLocation, processGroupId) |
There was a problem hiding this comment.
SnippetService.copySnippet is no longer user and can be deleted.
|
|
||
| @Injectable() | ||
| export class CopyEffects { | ||
| constructor(private actions$: Actions) {} |
There was a problem hiding this comment.
actions$ is unused and can be removed.
…ressed. added some minor positioning fixes as well.
…ressed. added some minor positioning fixes as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NIFI-13977
Review this in conjunction with the associated backend changes from PR #9535