Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Bp-2603} uorb:Update uorb info and uorb topic #2659

Merged
merged 2 commits into from
Oct 9, 2024

Conversation

jerpelea
Copy link
Contributor

@jerpelea jerpelea commented Oct 9, 2024

Summary

uorb adds interface for getting info
Add some sensor types from aosp( 6dof motion and gesture related types).

Impact

RELEASE

Testing

CI

@nuttxpr
Copy link

nuttxpr commented Oct 9, 2024

[Experimental Bot, please feedback here]

No, this PR does not meet the NuttX requirements.

Here's why and what's missing:

  • Insufficient Summary:
    • Why? The summary vaguely mentions adding sensor types but lacks a clear explanation of the necessity for this change. Is it for a new feature, compatibility, or bug fix?
    • What/How? It doesn't specify which "sensor types from aosp" are added or how the "uorb interface for getting info" functions.
    • Links: Missing are links to related NuttX issues or pull requests.
  • Incomplete Impact Assessment:
    • Impact details: The impact section only mentions "RELEASE" which is not informative. Each impact category needs a YES/NO answer and a description if YES. For example:
      • Is a new feature added? YES (Describe the new feature: What sensors are added? How are they used?)
      • Impact on user? (Will users need to change their code? Are there new configuration options?)
      • Impact on hardware? (Are specific sensors now required?)
  • Insufficient Testing Information:
    • Vague: "CI" is not enough. While CI passing is good, you need to provide more specific details about your local testing.
    • Missing Details:
      • Which build hosts were used? (OS, CPU, compiler versions)
      • Which targets were tested? (Architectures, boards, configurations)
      • No Logs: "Testing logs before change" and "Testing logs after change" sections are empty. You must provide actual log snippets demonstrating the change's effect.

To improve this PR:

  1. Expand the Summary: Clearly explain the reason for the change, the specific code affected, and how the changes work.
  2. Complete the Impact Assessment: Address each impact category with YES/NO and provide detailed descriptions where necessary.
  3. Provide Detailed Testing Information: List the specific build hosts and targets used, and include relevant log snippets showing the behavior before and after your changes.

@jerpelea
Copy link
Contributor Author

jerpelea commented Oct 9, 2024

#2661 needed

@jerpelea jerpelea changed the title {Bp-2603} {Bp-2603} uorb:Update uorb info and uorb topic Oct 9, 2024
@jerpelea jerpelea requested a review from lupyuen October 9, 2024 10:41
@xiaoxiang781216 xiaoxiang781216 merged commit 729e1ca into apache:releases/12.7 Oct 9, 2024
5 of 28 checks passed
@jerpelea jerpelea deleted the bp-2603 branch October 9, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants