Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{Bp-2647} net: Remove IFF_DOWN flag to compatible with Linux/*BSD #2661

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

jerpelea
Copy link
Contributor

@jerpelea jerpelea commented Oct 9, 2024

Summary

turn off interface by checking IFF_UP flag isn't set: apache/nuttx#1838

Impact

RELEASE

Testing

CI

turn off interface by checking IFF_UP flag isn't set:
apache/nuttx#1838

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@nuttxpr
Copy link

nuttxpr commented Oct 9, 2024

[Experimental Bot, please feedback here]

No, this PR does not meet the NuttX requirements.

Missing Information:

  • Summary:
    • Lack of details on the functional part of the code being changed.
    • No explanation of how the change works.
  • Impact:
    • Unclear what "RELEASE" means in this context.
    • Needs specific details about impact on users, build, hardware, documentation, security, compatibility, etc.
  • Testing:
    • "CI" is not sufficient. Specify the build hosts and targets used for testing.
    • No testing logs provided.

To meet the requirements, the PR needs to provide comprehensive information in all sections, including specific details and relevant logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants