Add carrier frequency for GNSS Satellite #2910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `struct sensor_gnss_satellite.cf` may be parsed from `GSV.signal_id`(e.g. NMEA 0183 v4.11) and `struct sensor_gnss_satellite.constellation` Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
Make it easier to extend the format of struct member Signed-off-by: wangjianyu3 <wangjianyu3@xiaomi.com>
|
@Donny9 Could you review this PR please? |
xiaoxiang781216
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The struct sensor_gnss_satellite.cf(carrier frequency) can be parsed from GSV.signal_id(e.g. NMEA 0183 v4.11) and struct sensor_gnss_satellite.constellation(sv_type)
See nuttx/uorb.h: Add carrier frequency for GNSS Satellite nuttx#15296
Impact
uORB/sensor
Testing
NuttX CI (depends on apache/nuttx#15296)