Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking issues of RFC-2299: Chain based Operator API #2300

Closed
11 tasks done
Xuanwo opened this issue May 23, 2023 · 6 comments
Closed
11 tasks done

Tracking issues of RFC-2299: Chain based Operator API #2300

Xuanwo opened this issue May 23, 2023 · 6 comments
Labels
core good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Xuanwo
Copy link
Member

Xuanwo commented May 23, 2023 •
edited
Loading

Changes

Please take #2303 as refercence.

  • Add a new FutureXxx struct which implements Future.
  • Replace async fn xxx_with(xxx) -> Result<Metadata> to fn xxx_with(xxx) -> FutureXxx
  • Add OpXxx's functions upon FutureXxx instead.

Tasks
@suyanhanx suyanhanx changed the title Tracking issues of RFC-2299: Chain based Operator AP Tracking issues of RFC-2299: Chain based Operator API May 23, 2023
@Xuanwo Xuanwo added good first issue Good for newcomers help wanted Extra attention is needed core labels May 24, 2023
@suyanhanx suyanhanx mentioned this issue May 24, 2023
Merged
@infdahai
Copy link
Contributor

@Xuanwo Can I impl the append_with part now? I am new here and it seems the part is easy for me by referring to #2303.

@Xuanwo
Copy link
Member Author

Xuanwo commented May 24, 2023

@Xuanwo Can I impl the append_with part now? I am new here and it seems the part is easy for me by referring to #2303.

Thanks a lot! Have fun!

This was referenced May 24, 2023
Merged
Merged
This was referenced May 24, 2023
Merged
Merged
Merged
Merged
Merged
Merged
@Xuanwo
Copy link
Member Author

Xuanwo commented May 25, 2023

Hello, @infdahai. Thank you for your dedication and hard work! The RFC is nearly complete, with just one remaining task: implementing list_with support. Are you available to help finalize it?

@infdahai
Copy link
Contributor

Just wait a minute.

@Xuanwo
Copy link
Member Author

Xuanwo commented May 25, 2023

Just wait a minute.

There is no hurry, have fun!

@Xuanwo
Copy link
Member Author

Xuanwo commented May 25, 2023

Thank @infdahai, all issues have been resolved!

@Xuanwo Xuanwo closed this as completed May 25, 2023
@Xuanwo Xuanwo mentioned this issue May 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Xuanwo @infdahai