Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Implement RFC-2299 for stat_with #2303

Merged
merged 3 commits into from
May 24, 2023
Merged

refactor(core): Implement RFC-2299 for stat_with #2303

merged 3 commits into from
May 24, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented May 24, 2023

part of #2300

from

if let Err(e) = op.stat_with("test", OpStat::new().with_if_match("<etag>")).await {
    if e.kind() == ErrorKind::NotFound {
        println!("file not exist")
    }
}

to

if let Err(e) = op.stat_with("test").if_match("<etag>").await {
    if e.kind() == ErrorKind::NotFound {
        println!("file not exist")
    }
}

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Copy link
Member Author

Xuanwo commented May 24, 2023

cc @suyanhanx to take another look.

Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@Xuanwo Xuanwo merged commit 5dc2736 into main May 24, 2023
@Xuanwo Xuanwo deleted the rfc-2299 branch May 24, 2023 10:02
@Xuanwo Xuanwo mentioned this pull request May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants