Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump to version 0.36.0 #2366

Merged
merged 6 commits into from
May 30, 2023
Merged

Bump to version 0.36.0 #2366

merged 6 commits into from
May 30, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented May 30, 2023

Added

Changed

Fixed

Docs

CI

Chore

@Xuanwo
Bump version
3946b32 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Format code
d4c2709 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Add changelog
e258314 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Add changelog
e7c91e4 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo
Fix typo
0132f5d 
Signed-off-by: Xuanwo <github@xuanwo.io>
suyanhanx
suyanhanx approved these changes May 30, 2023
View reviewed changes
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@Xuanwo
Fix build
735fcce 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo merged commit 1eecbb7 into main May 30, 2023
@Xuanwo Xuanwo deleted the release-0.36.0-rc1 branch May 30, 2023 08:12
tisonkun
tisonkun reviewed May 31, 2023
View reviewed changes
bindings/java/pom.xml
@@ -32,7 +32,7 @@

<groupId>org.apache.opendal</groupId>
<artifactId>opendal-java</artifactId>
<version>0.2.0-SNAPSHOT</version>
<version>0.36.0-SNAPSHOT</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Xuanwo could you share the script we do this simultaneous updates? I'd like to ensure and investigate how to do Maven releases automatically.

Copy link
Member Author

@Xuanwo Xuanwo May 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is changed by hand

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Xuanwo I check the version on 0.36.0 tag and it's still 0.36.0-SNAPSHOT.

For Java library releases, a formal release doesn't have a -SNAPSHOT suffix while a develop version does. Could you please update it like 0.36.0 for the following tags and keep it like 0.37.0-SNAPSHOT on the main branch after tagging.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, we will change it to 0.37.0 in next release. And is snapshot version required? I prefer not to provide snapshot version if possible.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's OK for no snapshots. Please ping me when you call 0.37.0 release so that I can update the release process correspondingly.

@tisonkun tisonkun mentioned this pull request Jun 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tisonkun tisonkun tisonkun left review comments

@suyanhanx suyanhanx suyanhanx approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Xuanwo @tisonkun @suyanhanx