Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): split docs build into small jobs #2356

Merged
merged 3 commits into from
May 29, 2023
Merged

chore(docs): split docs build into small jobs #2356

merged 3 commits into from
May 29, 2023

Conversation

suyanhanx
Copy link
Member

close #2349

Signed-off-by: suyanhanx <suyanhanx@gmail.com>
.github/workflows/docs.yml Outdated Show resolved Hide resolved
.github/workflows/docs.yml Outdated Show resolved Hide resolved
@Xuanwo
Copy link
Member

Xuanwo commented May 29, 2023

The slowest part is:

Mon, 29 May 2023 13:58:22 GMT Checking hdrs v0.2.0
Mon, 29 May 2023 14:08:21 GMT Checking rocksdb v0.20.1

.github/workflows/docs.yml Outdated Show resolved Hide resolved
Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@Xuanwo
Copy link
Member

Xuanwo commented May 29, 2023

Warn: Cannot find spec for opendal (from opendal):
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.11.3/x64/lib/python3.11/site-packages/pdoc/extract.py", line 62, in walk_specs
    raise ModuleNotFoundError(modname)
ModuleNotFoundError: opendal
 (/opt/hostedtoolcache/Python/3.11.3/x64/lib/python3.11/site-packages/pdoc/__init__.py:503)
Traceback (most recent call last):
  File "/opt/hostedtoolcache/Python/3.11.3/x64/bin/pdoc", line [8](https://github.com/apache/incubator-opendal/actions/runs/5112580053/jobs/9190790769?pr=2356#step:5:9), in <module>
    sys.exit(cli())
             ^^^^^
  File "/opt/hostedtoolcache/Python/3.11.3/x64/lib/python3.11/site-packages/pdoc/__main__.py", line 1[9](https://github.com/apache/incubator-opendal/actions/runs/5112580053/jobs/9190790769?pr=2356#step:5:10)2, in cli
    pdoc.pdoc(
  File "/opt/hostedtoolcache/Python/3.[11](https://github.com/apache/incubator-opendal/actions/runs/5112580053/jobs/9190790769?pr=2356#step:5:12).3/x64/lib/python3.11/site-packages/pdoc/__init__.py", line 503, in pdoc
    for module_name in extract.walk_specs(modules):
                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/hostedtoolcache/Python/3.11.3/x64/lib/python3.11/site-packages/pdoc/extract.py", line 85, in walk_specs
    raise ValueError(
ValueError: No modules found matching spec: opendal

Ok, we must have opendal first (

Signed-off-by: suyanhanx <suyanhanx@gmail.com>
@suyanhanx suyanhanx marked this pull request as ready for review May 29, 2023 14:18
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Xuanwo Xuanwo merged commit 5a109fe into main May 29, 2023
@Xuanwo Xuanwo deleted the split-docs branch May 29, 2023 14:18
@Xuanwo Xuanwo mentioned this pull request May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ci: Split docs build into different jobs
2 participants