Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add service doc for azdfs #2310

Merged
merged 3 commits into from
May 24, 2023
Merged

docs: add service doc for azdfs #2310

merged 3 commits into from
May 24, 2023

Conversation

dqhl76
Copy link
Member

@dqhl76 dqhl76 commented May 24, 2023 •
edited
Loading

Update #2304

localhost_3000_docs_services_azdfs (1)

Xuanwo
Xuanwo approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Xuanwo Xuanwo merged commit a189eef into apache:main May 24, 2023
@Xuanwo Xuanwo mentioned this pull request May 24, 2023
Closed
29 tasks
@dqhl76
Copy link
Member Author

dqhl76 commented May 24, 2023 •
edited
Loading

May be we also need to add use opendal::Scheme; for this https://github.com/apache/incubator-opendal/blob/a189eef962c8e2a30a371845d4aa0499c5c24803/website/docs/services/azblob.mdx?plain=1#L35
I will add it next time

@dqhl76 dqhl76 deleted the dqhl-docs branch May 24, 2023 13:58
@Xuanwo
Copy link
Member

Xuanwo commented May 24, 2023

May be we also need to add use opendal::Scheme; for this

https://github.com/apache/incubator-opendal/blob/a189eef962c8e2a30a371845d4aa0499c5c24803/website/docs/services/azblob.mdx?plain=1#L35

Yes, and we can remove use opendal::services::Azdfs.

@Xuanwo Xuanwo mentioned this pull request May 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dqhl76 @Xuanwo