Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(core): Implement RFC-2299 for append_with #2312

Merged
merged 3 commits into from
May 24, 2023
Merged

refactor(core): Implement RFC-2299 for append_with #2312

merged 3 commits into from
May 24, 2023

Conversation

infdahai
Copy link
Contributor

follows #2300.

@infdahai
refactor(core): Implement RFC-2299 for append_with
11083cc 
Signed-off-by: clundro <infdahai@outlook.com>
@infdahai
local test pass
ea899d3 
Signed-off-by: clundro <infdahai@outlook.com>
@infdahai
remove unused_import
0122b23 
Signed-off-by: clundro <infdahai@outlook.com>
Xuanwo
Xuanwo approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Xuanwo Xuanwo merged commit f2f4ab8 into apache:main May 24, 2023
@Xuanwo Xuanwo mentioned this pull request May 24, 2023
Closed
11 tasks
@infdahai infdahai deleted the sup_append_with branch May 24, 2023 17:36
@Xuanwo Xuanwo mentioned this pull request May 30, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

@ClSlaid ClSlaid Awaiting requested review from ClSlaid

@sundy-li sundy-li Awaiting requested review from sundy-li

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@infdahai @Xuanwo