Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(integrations/cloudfilter): read only cloud filter #4856

Merged
merged 3 commits into from
Jul 11, 2024

Conversation

ho-229
Copy link
Contributor

@ho-229 ho-229 commented Jul 5, 2024

This PR introduces a read only Cloud Filter implementation for access OpenDAL services on Windows.

@ho-229
Copy link
Contributor Author

ho-229 commented Jul 5, 2024

Hello @Xuanwo @oowl, PTAL.

Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit bfdd5a1 into apache:main Jul 11, 2024
27 checks passed
Lzzzzzt added a commit to Lzzzzzt/opendal that referenced this pull request Jul 12, 2024
Signed-off-by: Lzzzt <liuzitao0123@gmail.com>

feat(integrations/cloudfilter): read only cloud filter (apache#4856)

* feat: read only cloud filter

* fix: clippy

* chore: add license header

chore: Make compfs able to test (apache#4878)

* chore: Make compfs able to test

Signed-off-by: Xuanwo <github@xuanwo.io>

* Fix compfs reading

Signed-off-by: Xuanwo <github@xuanwo.io>

* Fix build

Signed-off-by: Xuanwo <github@xuanwo.io>

* Close file during close

Signed-off-by: Xuanwo <github@xuanwo.io>

* Fix typo

Signed-off-by: Xuanwo <github@xuanwo.io>

* Remove option

Signed-off-by: Xuanwo <github@xuanwo.io>

---------

Signed-off-by: Xuanwo <github@xuanwo.io>

chore(services/compfs): remove allow(dead_code) (apache#4879)

refactor: delete useless field in the `OpendalStore` due to the change of `Operator`

Signed-off-by: Lzzzt <liuzitao0123@gmail.com>

refactor: change the signature of `Access::info` and `AccessDyn::info`

Signed-off-by: Lzzzt <liuzitao0123@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants