chore: Make compfs able to test #4878
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
Xuanwo
commented
Jul 11, 2024
George-Miao
reviewed
Jul 11, 2024
George-Miao
reviewed
Jul 11, 2024
Signed-off-by: Xuanwo <github@xuanwo.io>
Lzzzzzt
added a commit
to Lzzzzzt/opendal
that referenced
this pull request
Jul 12, 2024
Signed-off-by: Lzzzt <liuzitao0123@gmail.com> feat(integrations/cloudfilter): read only cloud filter (apache#4856) * feat: read only cloud filter * fix: clippy * chore: add license header chore: Make compfs able to test (apache#4878) * chore: Make compfs able to test Signed-off-by: Xuanwo <github@xuanwo.io> * Fix compfs reading Signed-off-by: Xuanwo <github@xuanwo.io> * Fix build Signed-off-by: Xuanwo <github@xuanwo.io> * Close file during close Signed-off-by: Xuanwo <github@xuanwo.io> * Fix typo Signed-off-by: Xuanwo <github@xuanwo.io> * Remove option Signed-off-by: Xuanwo <github@xuanwo.io> --------- Signed-off-by: Xuanwo <github@xuanwo.io> chore(services/compfs): remove allow(dead_code) (apache#4879) refactor: delete useless field in the `OpendalStore` due to the change of `Operator` Signed-off-by: Lzzzt <liuzitao0123@gmail.com> refactor: change the signature of `Access::info` and `AccessDyn::info` Signed-off-by: Lzzzt <liuzitao0123@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will make compfs able to run.
The tests are still failing, but we can make it runnable first.