Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(bindings/go): always test against the latest core #4913

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

yuchanns
Copy link
Member

The go-binding currently uses a service based on v0.47.3 for testing and does not integrate the latest core.

With apache/opendal-go-services#2 now merged, we can use the script to generate the latest core and service, then test it using Go Workspace.

@yuchanns yuchanns force-pushed the go-binding-test-against-latest-core branch from bc2ae9f to a8faccd Compare July 19, 2024 03:02
@yuchanns yuchanns changed the title feat(ci/go-binding): always test against latest core feat(ci/go-binding): always test against test latest core Jul 19, 2024
@yuchanns yuchanns changed the title feat(ci/go-binding): always test against test latest core feat(ci/go-binding): always test against the latest core Jul 19, 2024
@yuchanns yuchanns force-pushed the go-binding-test-against-latest-core branch 3 times, most recently from 818cfe9 to 732d3c7 Compare July 19, 2024 04:11
@yuchanns
Copy link
Member Author

yuchanns commented Jul 19, 2024

@Xuanwo Hi I have noticed that if people use GOPROXY to get either github.com/apache/opendal/bindings/go or github.com/apache/opendal-go-services/memory then they will encounter problems such as:

GOPROXY=https://proxy.golang.org go get github.com/apache/opendal-go-services/aliyun_drive
go: module github.com/apache/opendal-go-services@upgrade found (v0.0.0-20240719030108-74ff217cfef9), but does not contain package github.com/apache/opendal-go-services/aliyun_drive

But they can succeed with:

unset GOPROXY
go get github.com/apache/opendal-go-services/aliyun_drive
go: downloading github.com/apache/opendal-go-services/aliyun_drive v0.0.0-20240719030108-74ff217cfef9
go: added github.com/apache/opendal-go-services/aliyun_drive v0.0.0-20240719030108-74ff217cfef9

I don't know why. But it can cause trouble for users.

@yuchanns yuchanns force-pushed the go-binding-test-against-latest-core branch from 732d3c7 to a77af99 Compare July 19, 2024 04:51
@Xuanwo
Copy link
Member

Xuanwo commented Jul 19, 2024

Hi @yuchanns, I suspect that GOPROXY's cache doesn't always refresh after new commits are pushed. Please try using go get github.com/apache/opendal-go-services/aliyun_drive@<hash>.

@yuchanns yuchanns force-pushed the go-binding-test-against-latest-core branch from a77af99 to 1103732 Compare July 19, 2024 04:53
@yuchanns yuchanns changed the title feat(ci/go-binding): always test against the latest core ci(bindings/go): always test against the latest core Jul 19, 2024
@yuchanns
Copy link
Member Author

Please try using go get github.com/apache/opendal-go-services/aliyun_drive@<hash>.

Fine. This works.

bindings/go/go.mod Outdated Show resolved Hide resolved
bindings/go/opendal_test.go Show resolved Hide resolved
@yuchanns yuchanns force-pushed the go-binding-test-against-latest-core branch 3 times, most recently from b3988fd to 85aabae Compare July 20, 2024 05:16
Signed-off-by: Hanchin Hsieh <me@yuchanns.xyz>
@yuchanns yuchanns force-pushed the go-binding-test-against-latest-core branch from 85aabae to 0e78893 Compare July 20, 2024 05:55
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Xuanwo Xuanwo merged commit 5e735cc into apache:main Jul 20, 2024
29 checks passed
@yuchanns yuchanns deleted the go-binding-test-against-latest-core branch July 20, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants