fix(bindings/python): Make sure read until EOF #4995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
changed the title
Xuanwo
reviewed
Aug 11, 2024
Xuanwo
requested changes
Aug 11, 2024
There was a problem hiding this comment.
Thank you for your effort. However, I believe this fix is incorrect.
The root cause lies in:
read_content = reader.read(size + 1)
where the length of read_content does not equal size + 1.
Therefore, we should not directly compare read_content with content. Instead, we need to gather all read_content and then perform the assertion.
This commit addresses the issue raised in the pull request apache#4989, where the `read()` operation did not always return the expected content length. Changes include: - Implementing a loop to gather all content chunks until EOF. - Performing the assertion after the entire content has been read. This ensures that the test passes stably by correctly handling cases where `read()` may not return the full content in one go.
Xuanwo
reviewed
Aug 13, 2024
Xuanwo
reviewed
Aug 14, 2024
Bicheka
commented
Aug 14, 2024
Xuanwo
changed the title
Xuanwo
approved these changes
Aug 15, 2024
There was a problem hiding this comment.
Thank you for your contribution first.
However, I'm not happy working on this PR with you. I feel like you haven't put in as much effort as I have. Sometimes, your changes make me feel like you're committing them without much thought.
Apologies in advance if I have made any wrong assumptions. Please let me know if there are areas where we can improve.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #4990
Rationale for this change
There wasn't any warantee that the entire file would fit inside the size variable therfore read in chunks until EOF in the case that the file size is large