Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bindings/python): Make sure read until EOF #4995

Merged
merged 6 commits into from
Aug 15, 2024
Merged

fix(bindings/python): Make sure read until EOF #4995

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a1488bc
Fix #4990 guarantees read until EOF
Bicheka Aug 10, 2024
19b2f92
Address code review feedback for solving issue #4990
Bicheka Aug 11, 2024
69031ee
Fix: Ensure full content is read before performing assertions
Bicheka Aug 11, 2024
0d0c08e
address pr code review comment
Bicheka Aug 13, 2024
f431516
addressed pr code review by deleting requested code in my pr
Bicheka Aug 14, 2024
389e317
Merge branch 'main' into main
Bicheka Aug 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion bindings/python/tests/test_read.py
View file
Open in desktop
Bicheka marked this conversation as resolved.
Show resolved Hide resolved
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,14 @@ def test_sync_reader(service_name, operator, async_operator):
assert read_content == content

with operator.open(filename, "rb") as reader:
read_content = reader.read(size + 1)
read_content = bytearray()
while True:
chunk = reader.read(size + 1)
if not chunk:
break
read_content.extend(chunk)

read_content = bytes(read_content)
assert read_content is not None
assert read_content == content

Expand Down
Loading