Initial support for Nodejs 8 #2080
Conversation
core/nodejs8Action/build.gradle
Outdated
| distDocker.finalizedBy('rmProxy') | ||
|
|
||
| task copyProxy(type: Copy) { | ||
| from '../nodejsActionBase' |
There was a problem hiding this comment.
Want to use the same method as outlined for the python runners?
See : https://github.com/openwhisk/openwhisk/blob/master/core/python2Action/build.gradle
There was a problem hiding this comment.
Good feedback, I will change it.
I took the example from swift3 runner
https://github.com/openwhisk/openwhisk/blob/master/core/swift3Action/build.gradle
There was a problem hiding this comment.
@markusthoemmes need some help here:
made changes to
ext.dockerImageName = 'nodejs8action'
apply from: '../../gradle/docker.gradle'
distDocker.dependsOn 'copyFiles'
distDocker.finalizedBy 'rmFiles'
def runners = files(
new File(project(':core:nodejsActionBase').projectDir)
)
task copyFiles(type: Copy) {
from runners
into '.'
}
task rmFiles(type: Delete) {
delete runners.collect { it.getName() }
}
But I get errors running distDocker
* What went wrong:
A problem occurred evaluating project ':core:nodejs8Action'.
> Could not find matching constructor for: java.io.File(java.io.File)
There was a problem hiding this comment.
nevermind figured it out
project(':core:nodejsActionBase').projectDir
|
The nodejs CTC has voted to move the release date back a few weeks in order to give more time for V8 5.8 among other things. The new target release date for 8.0.0 is May 30th. The new semver-major cutoff date will be May 9th |
|
It is ready. |
|
Yep I know |
|
adding nodejs8 will be done in the new repo |
Closes #2077
Tracking nodejs@8 release here nodejs/node#10117