-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial support for Nodejs 8 #2080
Closed
Closed
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,10 +9,6 @@ scala: | |
services: | ||
- docker | ||
|
||
env: | ||
global: | ||
- TERM=dumb | ||
|
||
notifications: | ||
email: false | ||
slack: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,95 @@ | ||
FROM buildpack-deps:xenial-scm | ||
|
||
ENV DEBIAN_FRONTEND noninteractive | ||
|
||
# Initial update and some basics. | ||
RUN apt-get update && apt-get install -y imagemagick && apt-get install -y unzip | ||
|
||
ADD ./nodejsAction /nodejsAction | ||
|
||
# based on https://github.com/nodejs/docker-node | ||
|
||
|
||
RUN groupadd --gid 1000 node \ | ||
&& useradd --uid 1000 --gid node --shell /bin/bash --create-home node | ||
|
||
|
||
ENV NPM_CONFIG_LOGLEVEL info | ||
ENV NODE_VERSION 8.0.0-test20170327db9805885fb817c5b36e5b2bb53b82c0765e438f | ||
|
||
RUN curl -SLO "https://nodejs.org/download/test/v$NODE_VERSION/node-v$NODE_VERSION-linux-x64.tar.gz" \ | ||
&& tar -xzf "node-v$NODE_VERSION-linux-x64.tar.gz" -C /usr/local --strip-components=1 \ | ||
&& rm "node-v$NODE_VERSION-linux-x64.tar.gz" \ | ||
&& ln -s /usr/local/bin/node /usr/local/bin/nodejs | ||
|
||
ENV YARN_VERSION 0.21.3 | ||
|
||
RUN set -ex \ | ||
&& curl -fSL -o yarn.js "https://yarnpkg.com/downloads/$YARN_VERSION/yarn-$YARN_VERSION.js" \ | ||
&& mv yarn.js /usr/local/bin/yarn \ | ||
&& chmod +x /usr/local/bin/yarn | ||
|
||
WORKDIR /nodejsAction | ||
|
||
# Install app dependencies | ||
RUN rm -rf .project .settings build.xml Dockerfile README node_modules logs | ||
RUN npm install . | ||
|
||
RUN npm install \ | ||
apn@2.1.2 \ | ||
async@2.1.4 \ | ||
body-parser@1.15.2 \ | ||
btoa@1.1.2 \ | ||
cheerio@0.22.0 \ | ||
cloudant@1.6.2 \ | ||
commander@2.9.0 \ | ||
consul@0.27.0 \ | ||
cookie-parser@1.4.3 \ | ||
cradle@0.7.1 \ | ||
errorhandler@1.5.0 \ | ||
express@4.14.0 \ | ||
express-session@1.14.2 \ | ||
glob@7.1.1 \ | ||
gm@1.23.0 \ | ||
lodash@4.17.2 \ | ||
log4js@0.6.38 \ | ||
iconv-lite@0.4.15 \ | ||
marked@0.3.6 \ | ||
merge@1.2.0 \ | ||
moment@2.17.0 \ | ||
mongodb@2.2.11 \ | ||
mustache@2.3.0 \ | ||
nano@6.2.0 \ | ||
node-uuid@1.4.7 \ | ||
nodemailer@2.6.4 \ | ||
oauth2-server@2.4.1 \ | ||
openwhisk@3.3.2 \ | ||
pkgcloud@1.4.0 \ | ||
process@0.11.9 \ | ||
pug@">=2.0.0-beta6 <2.0.1" \ | ||
redis@2.6.3 \ | ||
request@2.79.0 \ | ||
request-promise@4.1.1 \ | ||
rimraf@2.5.4 \ | ||
semver@5.3.0 \ | ||
sendgrid@4.7.1 \ | ||
serve-favicon@2.3.2 \ | ||
socket.io@1.6.0 \ | ||
socket.io-client@1.6.0 \ | ||
superagent@3.0.0 \ | ||
swagger-tools@0.10.1 \ | ||
tmp@0.0.31 \ | ||
twilio@2.11.1 \ | ||
underscore@1.8.3 \ | ||
uuid@3.0.0 \ | ||
validator@6.1.0 \ | ||
watson-developer-cloud@2.14.3 \ | ||
when@3.7.7 \ | ||
winston@2.3.0 \ | ||
ws@1.1.1 \ | ||
xml2js@0.4.17 \ | ||
xmlhttprequest@1.8.0 \ | ||
yauzl@2.7.0 | ||
|
||
# See app.js | ||
CMD node app.js |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
apply plugin: 'eclipse' | ||
eclipse { | ||
project { | ||
natures 'org.eclipse.wst.jsdt.core.jsNature' | ||
buildCommand 'org.eclipse.wst.jsdt.core.javascriptValidator' | ||
} | ||
} | ||
|
||
ext.dockerImageName = 'nodejs8action' | ||
apply from: '../../gradle/docker.gradle' | ||
distDocker.dependsOn 'copyProxy' | ||
distDocker.finalizedBy('rmProxy') | ||
|
||
task copyProxy(type: Copy) { | ||
from '../nodejsActionBase' | ||
into 'nodejsAction' | ||
} | ||
|
||
task rmProxy(type: Delete) { | ||
delete 'nodejsAction' | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Want to use the same method as outlined for the python runners?
See : https://github.com/openwhisk/openwhisk/blob/master/core/python2Action/build.gradle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good feedback, I will change it.
I took the example from swift3 runner
https://github.com/openwhisk/openwhisk/blob/master/core/swift3Action/build.gradle
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@markusthoemmes need some help here:
made changes to
But I get errors running
distDocker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nevermind figured it out