Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update travis badge for migration to travis-ci.com #5033

Closed
wants to merge 2 commits into from

Conversation

dgrove-oss
Copy link
Member

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 11, 2020

Codecov Report

Merging #5033 (62c62af) into master (4babe39) will decrease coverage by 47.81%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #5033       +/-   ##
===========================================
- Coverage   83.77%   35.96%   -47.82%     
===========================================
  Files         202      202               
  Lines        9818     9818               
  Branches      416      416               
===========================================
- Hits         8225     3531     -4694     
- Misses       1593     6287     +4694     
Impacted Files Coverage Δ
...a/org/apache/openwhisk/common/ConfigMapValue.scala 0.00% <0.00%> (-100.00%) ⬇️
.../apache/openwhisk/core/controller/Namespaces.scala 0.00% <0.00%> (-100.00%) ⬇️
...pache/openwhisk/core/controller/CorsSettings.scala 0.00% <0.00%> (-100.00%) ⬇️
...che/openwhisk/core/entitlement/RateThrottler.scala 0.00% <0.00%> (-100.00%) ⬇️
...he/openwhisk/core/entitlement/KindRestrictor.scala 0.00% <0.00%> (-100.00%) ⬇️
...penwhisk/core/database/cosmosdb/CosmosDBUtil.scala 0.00% <0.00%> (-100.00%) ⬇️
.../openwhisk/core/entitlement/ActionCollection.scala 0.00% <0.00%> (-100.00%) ⬇️
.../openwhisk/core/entitlement/LocalEntitlement.scala 0.00% <0.00%> (-100.00%) ⬇️
...nwhisk/core/database/cosmosdb/CosmosDBConfig.scala 0.00% <0.00%> (-100.00%) ⬇️
...openwhisk/core/entitlement/PackageCollection.scala 0.00% <0.00%> (-100.00%) ⬇️
... and 132 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4babe39...62c62af. Read the comment docs.

Copy link
Member

@style95 style95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, Dave to handle this.

@style95
Copy link
Member

style95 commented Dec 13, 2020

It seems flake8 is failed to run.

Flake8: first round (fast fail) stops the build if there are any Python 3 syntax errors...
Traceback (most recent call last):
  File "/home/travis/.local/bin/flake8", line 7, in <module>
    from flake8.main.cli import main
  File "/home/travis/.local/lib/python3.5/site-packages/flake8/main/cli.py", line 5, in <module>
    from flake8.main import application
  File "/home/travis/.local/lib/python3.5/site-packages/flake8/main/application.py", line 11, in <module>
    from flake8 import checker
  File "/home/travis/.local/lib/python3.5/site-packages/flake8/checker.py", line 18, in <module>
    from flake8 import processor
  File "/home/travis/.local/lib/python3.5/site-packages/flake8/processor.py", line 13, in <module>
    from flake8 import utils
  File "/home/travis/.local/lib/python3.5/site-packages/flake8/utils.py", line 16, in <module>
    from flake8._compat import lru_cache
  File "/home/travis/.local/lib/python3.5/site-packages/flake8/_compat.py", line 12, in <module>
    import importlib_metadata
  File "/home/travis/.local/lib/python3.5/site-packages/importlib_metadata/__init__.py", line 43, in <module>
    class PackageNotFoundError(ModuleNotFoundError):
NameError: name 'ModuleNotFoundError' is not defined

importlib_metadata has changed to submodule(importlib.metadata) since python3.8 and I suspect there are some issues in the flake8 though we are using python3.5 in Travis.

I think we can try to use python3.8 to clarify the issue.

@dgrove-oss
Copy link
Member Author

trying newer python makes sense. More generally, we are requesting xenial (16.04) as our ubuntu in travis. We should probably move to 18.04 or 20.04.

@style95
Copy link
Member

style95 commented Dec 18, 2020

@jiangpengcheng Could you open a new PR to upgrade python and underlying ubuntu version by replicating this PR to update the Travis info as well?
We can see if that fixes the issue.

@jiangpengcheng
Copy link
Contributor

ok

@style95
Copy link
Member

style95 commented Jan 7, 2021

@jiangpengcheng Would it be ok for me to work on this issue in parallel as this is the main bottleneck for now?

@jiangpengcheng
Copy link
Contributor

@style95 sure

@dgrove-oss
Copy link
Member Author

folded into #5042

@dgrove-oss dgrove-oss closed this Jan 15, 2021
@dgrove-oss dgrove-oss deleted the travis branch January 15, 2021 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants