-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate the Travis configuration to travis-ci.com #5042
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5042 +/- ##
==========================================
- Coverage 83.81% 76.81% -7.00%
==========================================
Files 202 202
Lines 9818 9818
Branches 416 416
==========================================
- Hits 8229 7542 -687
- Misses 1589 2276 +687
Continue to review full report at Codecov.
|
Can we use GitHub actions at all to speed some things up? |
@rabbah I reported the issue to the Travis team and they are investigating now. |
7d9b229
to
8020700
Compare
maybe try with github actions is a good option? I did tried with them and it worked well, additionally they are much faster than travis |
There's some discussion of GitHub Actions over on builds@apache recently (http://mail-archives.us.apache.org/mod_mbox/www-builds/). It seems like the backlog to execute GHA is fairly long for repos in the Apache org, so not clear they will be any better than travis. |
It's possible to run GHA "on prem" (some other cloud). Would we be able to do that? I can arrange for us to have some compute cycles. Any discussion on the dev list if that's permissible/within ASF guidelines? Maybe we need a dev list post about this? |
Tests are failed again due to the rate limit on the Docker hub.
IIRC, @rabbah requested an exemption to Docker, and seems it's not yet applied. Regarding the GHA "on prem", it's essential to have a stable CI environment as it's not easy for contributors to debug an issue with his change if the reason for CI test failures varies every time. With the indeterministic behavior of Travis CI, I am pro to GHA with the reliable underlying infrastructure. And if we can have on-prem environments, we can even set up a pull-through-cache proxy of the Docker hub for CI tests. |
Finally, it passed all tests. I observed many different reasons:
All of these should be addressed for better productivity. Also, it relies on python2, we need to migrate to python3 as soon as possible. |
@@ -44,6 +44,8 @@ kind create cluster --wait 5m | |||
export KUBECONFIG="$(kind get kubeconfig-path)" | |||
kubectl config set-context --current --namespace=default | |||
|
|||
# This is required because it is timed out to pull the image during the test. | |||
docker pull openwhisk/action-nodejs-v10:nightly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might want to pull all images in advance.
Description
Fix #5041
Related issue and scope
My changes affect the following components
Types of changes
Checklist: