Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update travis badge for migration to travis-ci.com #5036

Closed
wants to merge 6 commits into from

Conversation

jiangpengcheng
Copy link
Contributor

No description provided.

@jiangpengcheng jiangpengcheng changed the title Change travis update travis badge for migration to travis-ci.com Dec 18, 2020
@jiangpengcheng
Copy link
Contributor Author

the unit test still failed in scan.sh step, but didn't find any error logs:

image

from above image, the scan.sh should be completed successfully

@codecov-io
Copy link

codecov-io commented Dec 24, 2020

Codecov Report

Merging #5036 (ff87132) into master (4babe39) will decrease coverage by 11.27%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #5036       +/-   ##
===========================================
- Coverage   83.81%   72.54%   -11.28%     
===========================================
  Files         202      195        -7     
  Lines        9818     9553      -265     
  Branches      416      413        -3     
===========================================
- Hits         8229     6930     -1299     
- Misses       1589     2623     +1034     
Impacted Files Coverage Δ
...che/openwhisk/core/invoker/LogStoreCollector.scala 0.00% <0.00%> (-100.00%) ⬇️
...core/database/cosmosdb/RxObservableImplicits.scala 0.00% <0.00%> (-100.00%) ⬇️
...ore/database/cosmosdb/cache/CacheInvalidator.scala 0.00% <0.00%> (-100.00%) ⬇️
...e/database/cosmosdb/cache/ChangeFeedConsumer.scala 0.00% <0.00%> (-100.00%) ⬇️
...core/database/cosmosdb/CosmosDBArtifactStore.scala 0.00% <0.00%> (-95.48%) ⬇️
...sk/core/database/cosmosdb/CosmosDBViewMapper.scala 0.00% <0.00%> (-93.90%) ⬇️
...tabase/cosmosdb/cache/CacheInvalidatorConfig.scala 0.00% <0.00%> (-92.31%) ⬇️
...a/org/apache/openwhisk/http/BasicHttpService.scala 3.33% <0.00%> (-86.67%) ⬇️
...la/org/apache/openwhisk/http/BasicRasService.scala 16.66% <0.00%> (-83.34%) ⬇️
...enwhisk/connector/kafka/KamonMetricsReporter.scala 0.00% <0.00%> (-83.34%) ⬇️
... and 48 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4babe39...ff87132. Read the comment docs.

@style95
Copy link
Member

style95 commented Dec 26, 2020

    stderr: Traceback (most recent call last):
      File "/home/travis/build/apache/openwhisk/ansible/../tools/db/cleanUpActivations.py", line 24, in <module>
        import couchdb.client
    ImportError: No module named couchdb.client

It complains about the couchdb.client module.
And it seems it's failing in conjunction with some heisenbugs.

@@ -54,6 +54,7 @@ cache:
- $HOME/.gradle/wrapper/

before_install:
- sudo systemctl stop epmd.socket epmd.service
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

they are using 4369 port

@@ -41,7 +41,7 @@ cd $ROOTDIR
TERM=dumb ./gradlew checkScalafmtAll

# lint tests to all be actually runnable
MISSING_TESTS=$(grep -rL "RunWith" --include="*Tests.scala" tests)
MISSING_TESTS=$(grep -rL "RunWith" --include="*Tests.scala" tests || true)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ubuntu 20.04 will return an error for this command if grep matched nothing

@@ -34,7 +34,7 @@ function retry() {
pip install --user couchdb

# Ansible
pip install --user ansible==2.5.2
pip install --user ansible==2.8.18
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ansible 2.5.2 is not compatible with python3, and some of our ansible script doesn't compatible ansible versions beyond 2.8

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So do we need to migrate all scripts?
If so, it might be easier to fix the flake8 issue, for now, to normalize CI tests and incrementally introduce python3.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found just one error while using ansible2.10, which is in the cli/deploy.yml#name: "Download release archive to build directory ..."

the headers option for get_url should use map instead of string

@jiangpengcheng
Copy link
Contributor Author

strange failed test:

org.apache.openwhisk.core.admin.WskAdminTests > Wsk Admin CLI should adjust whitelist for namespace FAILED
    org.scalatest.exceptions.TestFailedException: "allowedKinds = [['nodejs:10', ]'blackbox']" was not equal to "allowedKinds = [[u'nodejs:10', u]'blackbox']"

@@ -252,7 +252,8 @@ class WskAdminTests extends TestHelpers with WskActorSystem with Matchers with B
// check correctly set
val lines = wskadmin.cli(Seq("limits", "get", subject)).stdout.linesIterator.toSeq
lines should have size 1
lines(0) shouldBe "allowedKinds = [u'nodejs:10', u'blackbox']"
lines(0) should (be("allowedKinds = [u'nodejs:10', u'blackbox']") or be(
"allowedKinds = ['nodejs:10', 'blackbox']"))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to be compatible with ubuntu20.04

@@ -44,6 +44,8 @@ kind create cluster --wait 5m
export KUBECONFIG="$(kind get kubeconfig-path)"
kubectl config set-context --current --namespace=default

docker pull openwhisk/action-nodejs-v10:nightly
docker pull openwhisk/dockerskeleton:nightly
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems travis ci machine will take a long time to pull images which make some tests failed

@rabbah
Copy link
Member

rabbah commented Jan 15, 2021

The PR shows there are two conflicts to resolve.

@jiangpengcheng
Copy link
Contributor Author

since this PR: #5042 has already resolved the CI error, I will close this one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants