-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update travis badge for migration to travis-ci.com #5036
Conversation
Codecov Report
@@ Coverage Diff @@
## master #5036 +/- ##
===========================================
- Coverage 83.81% 72.54% -11.28%
===========================================
Files 202 195 -7
Lines 9818 9553 -265
Branches 416 413 -3
===========================================
- Hits 8229 6930 -1299
- Misses 1589 2623 +1034
Continue to review full report at Codecov.
|
It complains about the couchdb.client module. |
5df94bc
to
68c8b74
Compare
@@ -54,6 +54,7 @@ cache: | |||
- $HOME/.gradle/wrapper/ | |||
|
|||
before_install: | |||
- sudo systemctl stop epmd.socket epmd.service |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they are using 4369 port
@@ -41,7 +41,7 @@ cd $ROOTDIR | |||
TERM=dumb ./gradlew checkScalafmtAll | |||
|
|||
# lint tests to all be actually runnable | |||
MISSING_TESTS=$(grep -rL "RunWith" --include="*Tests.scala" tests) | |||
MISSING_TESTS=$(grep -rL "RunWith" --include="*Tests.scala" tests || true) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems ubuntu 20.04 will return an error for this command if grep
matched nothing
@@ -34,7 +34,7 @@ function retry() { | |||
pip install --user couchdb | |||
|
|||
# Ansible | |||
pip install --user ansible==2.5.2 | |||
pip install --user ansible==2.8.18 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ansible 2.5.2 is not compatible with python3, and some of our ansible script doesn't compatible ansible versions beyond 2.8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So do we need to migrate all scripts?
If so, it might be easier to fix the flake8
issue, for now, to normalize CI tests and incrementally introduce python3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found just one error while using ansible2.10, which is in the cli/deploy.yml#name: "Download release archive to build directory ..."
the headers
option for get_url
should use map instead of string
strange failed test:
|
@@ -252,7 +252,8 @@ class WskAdminTests extends TestHelpers with WskActorSystem with Matchers with B | |||
// check correctly set | |||
val lines = wskadmin.cli(Seq("limits", "get", subject)).stdout.linesIterator.toSeq | |||
lines should have size 1 | |||
lines(0) shouldBe "allowedKinds = [u'nodejs:10', u'blackbox']" | |||
lines(0) should (be("allowedKinds = [u'nodejs:10', u'blackbox']") or be( | |||
"allowedKinds = ['nodejs:10', 'blackbox']")) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
to be compatible with ubuntu20.04
@@ -44,6 +44,8 @@ kind create cluster --wait 5m | |||
export KUBECONFIG="$(kind get kubeconfig-path)" | |||
kubectl config set-context --current --namespace=default | |||
|
|||
docker pull openwhisk/action-nodejs-v10:nightly | |||
docker pull openwhisk/dockerskeleton:nightly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems travis ci machine will take a long time to pull images which make some tests failed
The PR shows there are two conflicts to resolve. |
since this PR: #5042 has already resolved the CI error, I will close this one |
No description provided.