-
Notifications
You must be signed in to change notification settings - Fork 516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HDDS-10517. Recon - Add a UI component for showing DN decommissioning detailed status and info #6724
Conversation
… detailed status and info
@smitajoshi12 thanks for working on this patch. Looks like on datanodes page, you wait for / |
@devmadhuu It is taking time to reflect status in /datanodes page. /datanode api is called after each 60 seconds as default behaviour. will think how we can meet this condition. |
… detailed status and info
@devmadhuu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this smitha!
Have posted a few comments and I also have a few doubts on the additions you have made can you please take a look.
And also please resolve the conflict
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/api/db.json
Outdated
Show resolved
Hide resolved
hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/api/db.json
Outdated
Show resolved
Hide resolved
...src/main/resources/webapps/recon/ozone-recon-web/src/views/datanodes/decommissionSummary.tsx
Show resolved
Hide resolved
@smitajoshi12 we shouldn't show the initial tool tip from datanodes page " |
@devmadhuu |
@smitajoshi12 As discussed, pls change the operational state column value based on decommission info API on datanodes page. Showing tooltip is wrong because datanode decommissioning has already started. |
… detailed status and info Review COmment
@devmadhuu |
@smitajoshi12 kindly resolve the conflicts in your code. |
… detailed status and info Merge Conflict Solve
@devmadhuu |
@smitajoshi12 Pls resolve your conflicts. |
@devmadhuu |
@dombizita @devabhishekpal |
Resolved Merge Conflicts |
Can you finish all the pending changes on this patch @smitajoshi12 |
@ArafatKhan2198 |
… detailed status and info After Merge
… detailed status and info After Merge Conflict
… detailed status and info Space issue
… detailed status and info Space issue
… detailed status and info Space issue
… detailed status and info
...one/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/datanodes/datanodes.tsx
Outdated
Show resolved
Hide resolved
...one/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/datanodes/datanodes.tsx
Outdated
Show resolved
Hide resolved
...ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/overview/overview.tsx
Outdated
Show resolved
Hide resolved
...ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/overview/overview.tsx
Outdated
Show resolved
Hide resolved
… detailed status and info Review Comments
… detailed status and info Review Comments Review Changes
… detailed status and info Review Changes
@smitajoshi12 Thanks for improving the patch. Changes LGTM +1 |
Hi @smitajoshi12 , so I was suggesting to change the component layout as below: This would make sure we are not covering too much information for the DN with the popup |
@devabhishekpal we need that minimal information for a node which is in decommission stage. |
Thanks for letting me know @devmadhuu. |
@devabhishekpal |
… detailed status and info Review Comment
Done the changes in latest commit 8b82426 and other css changes will raise another JIRA as improvement. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the patch @smitajoshi12 , the changes look good to me.
Just a few minor comments for better code quality
this.setState({ | ||
isLoading: true | ||
}); | ||
if (this.state.record && this.state.summaryData !== 'null' && this.state.summaryData !== 'undefined') { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can be simplified to:
if (this.state.record && this.state.summaryData !== 'null' && this.state.summaryData !== 'undefined') { | |
if (this.state?.record && this.state?.summaryData) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done the changes in latest commit 3e08fb7 and done testing with local cluster data.
</> | ||
} | ||
{ | ||
containers !== null && containers !== undefined && Object.keys(containers).length !== 0 && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since containers is an object I think this can also be simplified to:
containers !== null && containers !== undefined && Object.keys(containers).length !== 0 && | |
containers && Object.keys(containers).length !== 0 && |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@devabhishekpal
Done the changes in latest commit 3e08fb7 and done testing with local cluster data.
// Need to check summarydata is not empty | ||
return ( | ||
<> | ||
{ (summaryData !== 'null' && summaryData !== 'undefined' && summaryData && summaryData.length !== 0) ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
{ (summaryData !== 'null' && summaryData !== 'undefined' && summaryData && summaryData.length !== 0) ? | |
{ (summaryData && summaryData.length !== 0) ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done the changes in latest commit 3e08fb7 and done testing with local cluster data.
...ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/overview/overview.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smitajoshi12, please review the final comments from @devabhishekpal. I have tested the patch, and both the layout and functionality are working well. The patch looks good to me.
… detailed status and info Review Comment
Thanks @smitajoshi12 for improving the patch. Now it LGTM +1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes @smitajoshi12
These changes looks good to me, +1
Thanks for the patch @smitajoshi12 & thanks @devabhishekpal @devmadhuu for the review. |
* master: (181 commits) HDDS-11289. Bump docker-maven-plugin to 0.45.0 (apache#7024) HDDS-11287. Code cleanup in XceiverClientSpi (apache#7043) HDDS-11283. Refactor KeyValueStreamDataChannel to avoid spurious IDE build issues (apache#7040) HDDS-11257. Ozone write does not work when http proxy is set for the JVM. (apache#7036) HDDS-11249. Bump ozone-runner to 20240729-jdk17-1 (apache#7003) HDDS-10517. Recon - Add a UI component for showing DN decommissioning detailed status and info (apache#6724) HDDS-11270. [hsync] Add DN layout version (HBASE_SUPPORT/version 8) upgrade test. (apache#7021) HDDS-11272. Statistics some node status information (apache#7025) HDDS-11278. Move code out of Hadoop util package (apache#7028) HDDS-11274. (addendum) Replace Hadoop annotations/configs with Ozone-specific ones HDDS-11274. Replace Hadoop annotations/configs with Ozone-specific ones (apache#7026) HDDS-11280. Add Synchronize in AbstractCommitWatcher.addAckDataLength (apache#7032) HDDS-11235. Spare InfoBucket RPC call in FileSystem#mkdir() call. (apache#6990) HDDS-11273. Bump commons-compress to 1.26.2 (apache#7023) HDDS-11225. Increase ipc.server.read.threadpool.size (apache#7007) HDDS-11224. Increase hdds.datanode.handler.count (apache#7011) HDDS-11259. [hsync] DataNode should verify HBASE_SUPPORT layout version for every PutBlock. (apache#7012) HDDS-11214. Added config to set rocksDB's max log file size and num of log files (apache#7014) HDDS-11226. Make ExponentialBackoffPolicy maxRetries configurable (apache#6985) HDDS-11260. [hsync] Add Ozone Manager protocol version (apache#7015) ... Conflicts: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/audit/DNAction.java hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/KeyValueHandler.java hadoop-hdds/interface-client/src/main/proto/DatanodeClientProtocol.proto hadoop-hdds/server-scm/src/test/java/org/apache/hadoop/hdds/scm/container/TestContainerReportHandler.java
…p-supervisor Merge conflicts are resolved but the change does not yet build. * HDDS-10239-container-reconciliation: (183 commits) HDDS-10376. Add a Datanode API to supply a merkle tree for a given container. (apache#6945) HDDS-11289. Bump docker-maven-plugin to 0.45.0 (apache#7024) HDDS-11287. Code cleanup in XceiverClientSpi (apache#7043) HDDS-11283. Refactor KeyValueStreamDataChannel to avoid spurious IDE build issues (apache#7040) HDDS-11257. Ozone write does not work when http proxy is set for the JVM. (apache#7036) HDDS-11249. Bump ozone-runner to 20240729-jdk17-1 (apache#7003) HDDS-10517. Recon - Add a UI component for showing DN decommissioning detailed status and info (apache#6724) HDDS-10926. Block deletion should update container merkle tree. (apache#6875) HDDS-11270. [hsync] Add DN layout version (HBASE_SUPPORT/version 8) upgrade test. (apache#7021) HDDS-11272. Statistics some node status information (apache#7025) HDDS-11278. Move code out of Hadoop util package (apache#7028) HDDS-11274. (addendum) Replace Hadoop annotations/configs with Ozone-specific ones HDDS-11274. Replace Hadoop annotations/configs with Ozone-specific ones (apache#7026) HDDS-11280. Add Synchronize in AbstractCommitWatcher.addAckDataLength (apache#7032) HDDS-11235. Spare InfoBucket RPC call in FileSystem#mkdir() call. (apache#6990) HDDS-11273. Bump commons-compress to 1.26.2 (apache#7023) HDDS-11225. Increase ipc.server.read.threadpool.size (apache#7007) HDDS-11224. Increase hdds.datanode.handler.count (apache#7011) HDDS-11259. [hsync] DataNode should verify HBASE_SUPPORT layout version for every PutBlock. (apache#7012) HDDS-11214. Added config to set rocksDB's max log file size and num of log files (apache#7014) ... Conflicts: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/ozoneimpl/OzoneContainer.java
…rrupt-files * HDDS-10239-container-reconciliation: (183 commits) HDDS-10376. Add a Datanode API to supply a merkle tree for a given container. (apache#6945) HDDS-11289. Bump docker-maven-plugin to 0.45.0 (apache#7024) HDDS-11287. Code cleanup in XceiverClientSpi (apache#7043) HDDS-11283. Refactor KeyValueStreamDataChannel to avoid spurious IDE build issues (apache#7040) HDDS-11257. Ozone write does not work when http proxy is set for the JVM. (apache#7036) HDDS-11249. Bump ozone-runner to 20240729-jdk17-1 (apache#7003) HDDS-10517. Recon - Add a UI component for showing DN decommissioning detailed status and info (apache#6724) HDDS-10926. Block deletion should update container merkle tree. (apache#6875) HDDS-11270. [hsync] Add DN layout version (HBASE_SUPPORT/version 8) upgrade test. (apache#7021) HDDS-11272. Statistics some node status information (apache#7025) HDDS-11278. Move code out of Hadoop util package (apache#7028) HDDS-11274. (addendum) Replace Hadoop annotations/configs with Ozone-specific ones HDDS-11274. Replace Hadoop annotations/configs with Ozone-specific ones (apache#7026) HDDS-11280. Add Synchronize in AbstractCommitWatcher.addAckDataLength (apache#7032) HDDS-11235. Spare InfoBucket RPC call in FileSystem#mkdir() call. (apache#6990) HDDS-11273. Bump commons-compress to 1.26.2 (apache#7023) HDDS-11225. Increase ipc.server.read.threadpool.size (apache#7007) HDDS-11224. Increase hdds.datanode.handler.count (apache#7011) HDDS-11259. [hsync] DataNode should verify HBASE_SUPPORT layout version for every PutBlock. (apache#7012) HDDS-11214. Added config to set rocksDB's max log file size and num of log files (apache#7014) ... Conflicts: hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/checksum/ContainerChecksumTreeManager.java hadoop-hdds/container-service/src/test/java/org/apache/hadoop/ozone/container/checksum/TestContainerChecksumTreeManager.java
What changes were proposed in this pull request?
UI component has been added with some drill down on a DN which is under decommissioning.
Backend PR For Reference:-
https://github.com/apache/ozone/pull/6376##
What is the link to the Apache JIRA
(https://issues.apache.org/jira/browse/HDDS-10517)
How was this patch tested?
Manually
New Enhancemnet Tested with Cluster data in local
After Hovering on UUID Column
Tooltip has been added before hover
Once Status becomes Decommissioned decommission details will not be shown.
From Backend if we get Empty response from decommission api will not showing any details about decommission.
Handled all negative test cases for empty and null data if one Api's fail other apis working