HDDS-11032. Decommissioned datanodes shows up again after removing in Recon Datanodes page. #6833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er removing in Recon Datanodes page.
adoroszlai
changed the title
|
@sumitagrawl @ArafatKhan2198 Pls review. |
ArafatKhan2198
approved these changes
Jun 19, 2024
There was a problem hiding this comment.
Thanks for the fix, @devmadhuu! The changes in the PR look good! LGTM +1
Should we also update the UI to indicate that only dead nodes are allowed to be removed?
Yes, we have UI PR which has changes to allow only those node having DEAD node status . |
|
Thanks for the patch @devmadhuu and @sumitagrawl for the review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR is to stop showing Decommissioned datanodes again on Recon Datanodes page after removing them explicitly.
Ozone Recon - Decommissioned datanodes shows up again after removing in Recon Datanodes page.
As part of HDDS-10409
Recon was allowing to remove the Decommissioned datanodes and was removing from Recon rocksDB nodes table, however Decommissioned datanodes continue to send heartbeats till they are being shutdown, so they get registered and added again in Recon memory map which makes them show up again in datanodes UI.
Solution is to allow only DEAD datanodes to be removed and skip other node status or node operational status datanodes.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-11032
How was this patch tested?
This patch was tested by updating the existing integration test to make sure that only DEAD datanodes are being allowed to remove.