HDDS-11714. resetDeletedBlockRetryCount with --all may fail and can cause long db lock in large cluster

[aryangupta1998]

What changes were proposed in this pull request?

In case of resetDeletedBlockRetryCount with --all option, scm takes lock and tries to get all the transaction with max retry and then updates DB with 0 count. In some large scale env this count can be huge which can lead to multiple problem.

i) Lock can lead to block all other normal operation.

ii) Since message is passed through ratis, which will fail because of size.

Instead of doing like above we should do this operation in batches to avoid long lock and ratis message size failure.

What is the link to the Apache JIRA

https://issues.apache.org/jira/browse/HDDS-11714

How was this patch tested?

Tested Manually.

[nandakumar131]

Why do we need this additional method? The same thing can be achieved with the existing getFailedTransactions method.

[aryangupta1998]

Done

[nandakumar131]

The user provided list of txIDs reaches SCM via RPC call, so it's ok to process this in single go.

[aryangupta1998]

Done

[nandakumar131]

Please avoid unnecessary formatting.

[nandakumar131]

Please avoid unnecessary formatting.

[nandakumar131]

Please avoid unnecessary formatting.

[nandakumar131]

You can simplify the whole logic

public int resetCount(List<Long> txIDs) throws IOException {

  if (txIDs != null) {
     try {
        lock.lock();
        transactionStatusManager.resetRetryCount(txIDs);
        return deletedBlockLogStateManager.resetRetryCountOfTransactionInDB(
            new ArrayList<>(txIDs));
     } finally {
        lock.unlock();
     } catch (Exception e) {
      throw new IOException("Error during transaction reset", e);
     }
  }

  final int batchSize = 1000;
  int totalProcessed = 0;
  long startTxId = 0;

  try {
      // If txIDs are not provided, fetch all failed transactions in batches
      List<DeletedBlocksTransaction> batch;
      do {
          // Fetch the batch of failed transactions
          batch = getFailedTransactions(batchSize, startTxId);
          List<Long> batchTxIDs = batch.stream().map(DeletedBlocksTransaction::getTxID).collect(Collectors.toList());
          totalProcessed += resetCount(batchTxIDs);

          // Update startTxId to continue from the last processed transaction in the next iteration
          startTxId = batch.get(batch.size() - 1).getTxID() + 1;
      } while (!batch.isEmpty());
   }
   retrun totalProcessed;
}

[nandakumar131]

@aryangupta1998 the test failure seems related to this change, can you take a look at it?

[aryangupta1998]

Thanks @nandakumar131, fixed the test case!

[sadanand48]

LGTM

[nandakumar131]

Thanks @aryangupta1998 for the contribution. Thanks @sadanand48 for the review.