Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.1.0 release notes #861

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

pjfanning
Copy link
Contributor

release under discussion

@pjfanning pjfanning marked this pull request as draft October 9, 2024 13:53
@JD557
Copy link
Contributor

JD557 commented Oct 29, 2024

Should the release notes have an extra note regarding #314, as it is a breaking change?

At least from the wording in the changelog (Remove duplicate scopes value in reference.conf) it was not entirely obvious to me that this could break applications that were loading the scope from the service-account.scopes.

@pjfanning
Copy link
Contributor Author

pjfanning commented Oct 29, 2024

@mdedetrich what do you think about this being a breaking change (#314 )?

I guess we can move this into its own 'Potentially Breaking Changes' section and try to provide more details about who might see issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants