Allow cluster formation with mixed protocols #1568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cherry pick e4fa6f5 |
|
(yes - 'well actually' I cherry-picked 33156d2 but that pretty much amounts to the same thing since we squash-and-merge in Pekko) |
He-Pin
reviewed
Nov 27, 2024
| logWarning( | ||
| "Trying to join member with wrong protocol, but was ignored, expected [{}] but was [{}]", | ||
| selfAddress.protocol, | ||
| "Trying to join member with wrong protocol, but was ignored, expected any of {} but was [{}]", |
There was a problem hiding this comment.
hmm good point, I missed that in the original PR. IMO we can fix this on the main branch but don't need to revisit the backport.
pjfanning
added a commit
to pjfanning/incubator-pekko
that referenced
this pull request
Dec 16, 2024
pjfanning
added a commit
that referenced
this pull request
Dec 16, 2024
This reverts commit c2d1d9a.
pjfanning
added a commit
that referenced
this pull request
Dec 16, 2024
pjfanning
added a commit
that referenced
this pull request
Dec 16, 2024
|
reverted in #1588 |
pjfanning
added a commit
to pjfanning/incubator-pekko
that referenced
this pull request
Dec 16, 2024
This reverts commit 7af03e5.
pjfanning
added a commit
to pjfanning/incubator-pekko
that referenced
this pull request
Dec 28, 2024
This reverts commit 7af03e5.
pjfanning
added a commit
to pjfanning/incubator-pekko
that referenced
this pull request
Dec 30, 2024
This reverts commit 7af03e5.
pjfanning
added a commit
that referenced
this pull request
Jan 1, 2025
* Revert "revert #1568 due to test failures (#1587)" This reverts commit 7af03e5. * temp run nightly test in this PR * no need for square brackets because the set print adds them * logging to find issue * support tcp protocols * Update ClusterDaemon.scala * remove temp logging * try to fix issue in Remoting * extra tests * more tests * ignore udp tests * try to make tests tidy up after failures * Update MixedProtocolClusterSpec.scala * Update MixedProtocolClusterSpec.scala * run main cluster tests for PR
pjfanning
added a commit
to pjfanning/incubator-pekko
that referenced
this pull request
Jan 2, 2025
* Revert "revert apache#1568 due to test failures (apache#1587)" This reverts commit 7af03e5. * temp run nightly test in this PR * no need for square brackets because the set print adds them * logging to find issue * support tcp protocols * Update ClusterDaemon.scala * remove temp logging * try to fix issue in Remoting * extra tests * more tests * ignore udp tests * try to make tests tidy up after failures * Update MixedProtocolClusterSpec.scala * Update MixedProtocolClusterSpec.scala * run main cluster tests for PR
pjfanning
added a commit
that referenced
this pull request
Jan 2, 2025
* Revert "revert #1568 due to test failures (#1587)" This reverts commit 7af03e5. * temp run nightly test in this PR * no need for square brackets because the set print adds them * logging to find issue * support tcp protocols * Update ClusterDaemon.scala * remove temp logging * try to fix issue in Remoting * extra tests * more tests * ignore udp tests * try to make tests tidy up after failures * Update MixedProtocolClusterSpec.scala * Update MixedProtocolClusterSpec.scala * run main cluster tests for PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
backport of #1567