reimplement fix for akka/pekko cluster (#1594) #1664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Revert "revert apache#1568 due to test failures (apache#1587)" This reverts commit 7af03e5. * temp run nightly test in this PR * no need for square brackets because the set print adds them * logging to find issue * support tcp protocols * Update ClusterDaemon.scala * remove temp logging * try to fix issue in Remoting * extra tests * more tests * ignore udp tests * try to make tests tidy up after failures * Update MixedProtocolClusterSpec.scala * Update MixedProtocolClusterSpec.scala * run main cluster tests for PR
He-Pin
reviewed
Jan 2, 2025
| - cluster/test distributed-data/test cluster-tools/test cluster-metrics/test | ||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 |
There was a problem hiding this comment.
when the PR targets a branch, GitHub CI seems intelligent enough to checkout the PR branch
Have a look at https://github.com/apache/pekko/blob/1.0.x/.github/workflows/build-test-prValidation.yml -- no refs for any checkouts.
The nightly runs are different because we have the ymls in the main branch so if we want to test a branch, we need to adjust the checkouts in that case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry pick ef212e9 #1594