Fixing requestId generator bug in PinotBrokerDebug Resource #13716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ege-st
reviewed
Jul 30, 2024
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotBrokerDebug.java
Outdated
Show resolved
Hide resolved
xiangfu0
force-pushed
the
routing-table-api
branch
from
464b7ab to
a137615
Compare
pinot-broker/src/main/java/org/apache/pinot/broker/api/resources/PinotBrokerDebug.java
Outdated
Show resolved
Hide resolved
xiangfu0
force-pushed
the
routing-table-api
branch
from
a137615 to
7c50669
Compare
ankitsultana
approved these changes
Jul 30, 2024
mayankshriv
approved these changes
Jul 30, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13716 +/- ##
============================================
+ Coverage 61.75% 61.99% +0.24%
+ Complexity 207 198 -9
============================================
Files 2436 2554 +118
Lines 133233 140661 +7428
Branches 20636 21880 +1244
============================================
+ Hits 82274 87205 +4931
- Misses 44911 46824 +1913
- Partials 6048 6632 +584
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Are we going to create a new class for each http request? That is surprising |
suddendust
pushed a commit
to suddendust/incubator-pinot
that referenced
this pull request
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The issue here is that
_requestIdGeneratoris local to the HttpResource and will be created for every http request, so the requestId is always 0.