Update Helm chart versions #1944

flyrain · 2025-06-25T19:15:43Z

No description provided.

adutra · 2025-06-25T19:17:49Z

helm/polaris/Chart.yaml

 type: application
-version: 0.1.0
-appVersion: 1.0.0-incubating-SNAPSHOT
+version: 1.0.0


Do we want the Helm chart versioning to always follow the versioning of the underlying app?

We don't have to, but we need to update it every time we update the helm-chart itself, see details here, #1944 (comment). I'm OK with other version number, any suggestions?

I'm OK with 1.0.0, and I am OK releasing the Helm chart every time we release Polaris, updating version and appVersion.

I am just mentioning this because we never finished the discussion started here:

https://lists.apache.org/thread/rrsjygxdltnbtldyo3zl9x0v0h1t614h

And so I don't know if there is a consensus here.

Thanks for sharing the thread, that's helpful. I didn't see any objection there. I'm also supportive of release helm charts separately from the main source / binary bundle.

And so I don't know if there is a consensus here.

two +1s and no objection for a long time, which is usually considered as a consensus. It'd be nice to conclude it though.

Thanks for reviving the discussion 🙏

Sure, would you mind chiming in a bit. I hope it can conclude soon. I'm OK if we didn't figure out helm chart release for 1.0.0, but it'd be nice to have it.

Should we move this discussion to the dev ML?

Yufei revived that old thread, and I just added my +1 to his suggestions, FYI.

Yeah, we did, here are new discussions: https://lists.apache.org/thread/d1vf7xpn6nkzp8gbh417m8qb58tkpcqz

flyrain · 2025-06-25T19:18:15Z

helm/polaris/Chart.yaml

 type: application
-version: 0.1.0
-appVersion: 1.0.0-incubating-SNAPSHOT
+version: 1.0.0


Helm uses version to track the chart package itself (for repo indexes, upgrades, roll-backs, dependency resolution). It has nothing to do with the container image. It must be valid SemVer. It was recommend to update every time we update the helm chart itself.

Yes, I know that. But why jump from 0.1.0 to 1.0.0 then?

No particular reason, can you suggest a version?

flyrain · 2025-06-25T19:19:37Z

helm/polaris/Chart.yaml

-version: 0.1.0
-appVersion: 1.0.0-incubating-SNAPSHOT
+version: 1.0.0
+appVersion: 1.0.0-incubating


This is the docker image tag. The 1.0.0-incubating docker image will be published after the vote passed per release guide suggsted.

appVersion has nothing to do with the docker image tag. The docker image tag is set in values.yaml at image.tag.

We must keep in mind that a Helm chart published under appVersion X should stay compatible with a wide range of Docker images, roughly going from X-N to X, where N is yet to be defined. At some point, it could be useful to keep a formal compatibility matrix somewhere.

Thanks for the correction. In that case, should we update the tag from latest to 1.0.0-incubating in file values.yaml?

We must keep in mind that a Helm chart published under appVersion X should stay compatible with a wide range of Docker images, roughly going from X-N to X, where N is yet to be defined. At some point, it could be useful to keep a formal compatibility matrix somewhere.

How do we archive the the range compatibility? I guess X is 1.0.0-incubating for the Polaris release 1.0.0-incubating. Is there any default value for N?

There are pros and cons:

latest is very convenient, but at the same time, not very precise.

Specifying a fixed version in image.tag, on the contrary, has the merit of making it clear that the Helm chart works best for that specific tag.

I am personally in favor of using image.tag = latest, because if people also install the latest version of the helm chart, and provided that we publish images and charts at every release, then they should automatically get a latest chart version that works well with the latest docker image version.

LGTM overall. The only concern is that if users want to revert to a historical version of helm chart, do they expect to still get the latest docker image?

Here is an example, which assumes Helm chart version matched with Polaris src/bin/docker version:

When an user revert to the Helm Chart v1.0.0, it still points the latest docker image, which could be 1.1.0 already. This introduces the incompatible risks. On the other hand, if we specified a version(e.g., 1.0.0) instead of latest, the Helm reversion will always be same.

if people install the latest version of the helm chart, it still points to the latest docker image as we release them together. So that use case is covered as well.

With that, I think specifying a version is preferrable than latest. WDYT?

That's a valid point! latest is not very friendly to historical chart versions. I am OK with using the release version instead.

flyrain · 2025-06-25T20:06:00Z

I will convert this to draft as there are open discussions on helm chart release and tag.

… particular docker image tag

dimas-b

Approving per dev ML discussion

sfc-gh-ygu · 2025-06-25T22:26:44Z

Thanks @adutra and @dimas-b for the review. Will file a similar PR to main soon.

Update Helm chart versions

685cd5e

github-project-automation bot added this to Basic Kanban Board Jun 25, 2025

github-project-automation bot moved this to PRs In Progress in Basic Kanban Board Jun 25, 2025

flyrain marked this pull request as ready for review June 25, 2025 19:15

flyrain requested review from HonahX, MonkeyCanCode, RussellSpitzer, adutra, ajantha-bhat, ashvina, collado-mike, dennishuo, dimas-b, ebyhr, eric-maynard, jackye1995, jbonofre, pingtimeout, singhpk234, snazy, takidau and vvcephei as code owners June 25, 2025 19:15

adutra reviewed Jun 25, 2025

View reviewed changes

flyrain commented Jun 25, 2025

View reviewed changes

flyrain marked this pull request as draft June 25, 2025 20:06

Update the tag to make sure this Helm chart version works best with a…

a6bf6f5

… particular docker image tag

flyrain marked this pull request as ready for review June 25, 2025 21:19

dimas-b approved these changes Jun 25, 2025

View reviewed changes

github-project-automation bot moved this from PRs In Progress to Ready to merge in Basic Kanban Board Jun 25, 2025

flyrain merged commit 0fab43e into apache:release/1.0.x Jun 25, 2025
2 checks passed

github-project-automation bot moved this from Ready to merge to Done in Basic Kanban Board Jun 25, 2025

adutra mentioned this pull request Jul 16, 2025

Remove postgres_latest as image tag #2045

Merged

Update Helm chart versions #1944

Update Helm chart versions #1944

Uh oh!

Conversation

flyrain commented Jun 25, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

flyrain Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

flyrain commented Jun 25, 2025

Uh oh!

dimas-b left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

sfc-gh-ygu commented Jun 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

flyrain Jun 25, 2025 •

edited

Loading